fix(backend): convert ecosystem-phase2 test to Vitest, fix .ts extension + hardcoded productId

- ecosystem-phase2.test.ts used node:test — Vitest discovered it but ran 0 tests
- Converted to Vitest describe/it/expect — now 2 tests actually execute
- Added coverage for missing plan-created-event graceful fallback
- Fixed .ts import extension to .js (ESM convention, tsc build compat)
- Replaced 6 hardcoded 'chronomind' literals with PRODUCT_ID import
This commit is contained in:
saravanakumardb1 2026-04-13 15:51:58 -07:00
parent fcd2ee3ad2
commit 9b398bbd68
2 changed files with 72 additions and 58 deletions

View File

@ -1,5 +1,4 @@
import test from 'node:test';
import assert from 'node:assert/strict';
import { describe, it, expect } from 'vitest';
import { mkdir, mkdtemp, readFile, writeFile } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
@ -8,9 +7,10 @@ import {
loadLatestPlanArtifact,
loadLatestPlanCreatedEvent,
persistRoutineFromPlan,
} from './ecosystem-phase2.ts';
} from './ecosystem-phase2.js';
test('builds and persists a ChronoMind routine from the latest plan artifact', async () => {
describe('ecosystem-phase2', () => {
it('builds and persists a routine from the latest plan artifact', async () => {
const root = await mkdtemp(join(tmpdir(), 'chronomind-phase2-'));
await mkdir(join(root, 'indexes'), { recursive: true });
await writeFile(
@ -51,8 +51,14 @@ test('builds and persists a ChronoMind routine from the latest plan artifact', a
now: '2026-04-03T12:05:00.000Z',
});
assert.equal(generated.routine.steps.length, 2);
assert.equal(generated.createdEvent.trace.causationId, 'evt_plan_created_demo');
expect(generated.routine.steps).toHaveLength(2);
expect(generated.routine.steps[0].label).toBe('Architecture review');
expect(generated.routine.steps[1].label).toBe('API design');
expect(generated.routine.totalDurationMinutes).toBe(105);
expect(generated.routine.status).toBe('ready');
expect(generated.routine.isTemplate).toBe(true);
expect(generated.createdEvent.trace.causationId).toBe('evt_plan_created_demo');
expect(generated.artifact.payload.stepCount).toBe(2);
await persistRoutineFromPlan({ ...generated, root });
@ -60,5 +66,12 @@ test('builds and persists a ChronoMind routine from the latest plan artifact', a
await readFile(join(root, 'indexes', 'latest-routine-linked-event.json'), 'utf-8')
) as { payload: { relation: string } };
assert.equal(linkedEvent.payload.relation, 'generated-routine');
expect(linkedEvent.payload.relation).toBe('generated-routine');
});
it('handles missing plan-created-event gracefully', async () => {
const root = await mkdtemp(join(tmpdir(), 'chronomind-phase2-'));
const result = await loadLatestPlanCreatedEvent(root);
expect(result).toBeNull();
});
});

View File

@ -2,7 +2,8 @@ import { randomUUID } from 'node:crypto';
import { mkdir, readFile, writeFile } from 'node:fs/promises';
import { homedir } from 'node:os';
import { dirname, join } from 'node:path';
import type { RoutineDoc, RoutineStep } from '../modules/routines/types.ts';
import type { RoutineDoc, RoutineStep } from '../modules/routines/types.js';
import { PRODUCT_ID } from './product-config.js';
const DEFAULT_PHASE2_ROOT = join(homedir(), '.bytelyst', 'ecosystem', 'phase2');
@ -45,7 +46,7 @@ type RoutineArtifact = {
id: string;
artifactType: 'routine';
schemaVersion: 1;
productId: 'chronomind';
productId: typeof PRODUCT_ID;
sourceSurface: 'backend';
title: string;
summary: string;
@ -79,7 +80,7 @@ type ArtifactEvent = {
eventName: 'artifact.created' | 'artifact.linked';
eventVersion: 1;
occurredAt: string;
productId: 'chronomind';
productId: typeof PRODUCT_ID;
sourceSurface: 'backend';
userId: string;
orgId: string | null;
@ -139,7 +140,7 @@ export function buildRoutineFromPlan(params: {
const routine: RoutineDoc = {
id: routineId,
userId: params.planArtifact.ownership.userId,
productId: 'chronomind',
productId: PRODUCT_ID,
name: `Routine from ${params.planArtifact.title}`,
description: params.planArtifact.title,
steps,
@ -157,7 +158,7 @@ export function buildRoutineFromPlan(params: {
id: artifactId,
artifactType: 'routine',
schemaVersion: 1,
productId: 'chronomind',
productId: PRODUCT_ID,
sourceSurface: 'backend',
title: routine.name,
summary: `${steps.length} routine steps imported from FlowMonk plan`,
@ -206,7 +207,7 @@ export function buildRoutineFromPlan(params: {
eventName: 'artifact.created',
eventVersion: 1,
occurredAt: now,
productId: 'chronomind',
productId: PRODUCT_ID,
sourceSurface: 'backend',
userId: routine.userId,
orgId: params.planArtifact.ownership.orgId ?? null,
@ -231,7 +232,7 @@ export function buildRoutineFromPlan(params: {
eventName: 'artifact.linked',
eventVersion: 1,
occurredAt: now,
productId: 'chronomind',
productId: PRODUCT_ID,
sourceSurface: 'backend',
userId: routine.userId,
orgId: params.planArtifact.ownership.orgId ?? null,