diff --git a/docs/AUDIT_PLATFORM.md b/docs/AUDIT_PLATFORM.md index b8a7f511..883024bd 100644 --- a/docs/AUDIT_PLATFORM.md +++ b/docs/AUDIT_PLATFORM.md @@ -12,12 +12,12 @@ Legend: ๐Ÿ”ด critical ยท ๐ŸŸ  high ยท ๐ŸŸก medium ยท ๐ŸŸข low ยท ## 0. Health snapshot -| Check | Result | Notes | -| ----------------- | ------- | --------------------------------------------------------------------------------------------------- | -| `pnpm install -r` | โœ… pass | No warnings when `GITEA_NPM_TOKEN` is exported after sourcing `~/.zshrc`. | -| `pnpm typecheck` | โœ… pass | All TS sources compile (`tsc --noEmit`). | -| `pnpm test` | โœ… pass | ~2,200 tests across 18+ test suites; one cowork-service `EPIPE` flake cleared on focused rerun. | -| `pnpm lint` | โœ… pass | Workspace lint exits 0 with 0 errors / 173 warnings after post-agent reconciliation. See section W. | +| Check | Result | Notes | +| ----------------- | ------- | ----------------------------------------------------------------------------------------------- | +| `pnpm install -r` | โœ… pass | No warnings when `GITEA_NPM_TOKEN` is exported after sourcing `~/.zshrc`. | +| `pnpm typecheck` | โœ… pass | All TS sources compile (`tsc --noEmit`). | +| `pnpm test` | โœ… pass | ~2,200 tests across 18+ test suites; one cowork-service `EPIPE` flake cleared on focused rerun. | +| `pnpm lint` | โœ… pass | Workspace lint exits 0 with 0 errors / 157 warnings after `1089597`. See section W. | ## A. Lint pipeline blockers (fixed by this audit) @@ -58,8 +58,7 @@ The stale handoff note expected 85 pre-existing errors, but a live rerun on Remaining lint output is warnings only. The largest groups are still `no-console` in CLI tools, code generators, and diagnostic/runtime review areas (`create-app`, `keyvault`, `sidecar-monitor`, platform `gen-module`, -`migrate-referrals`, push notifications, and diagnostics modules), plus the -remaining admin-web React hook/image/unused-symbol warnings. These are +`migrate-referrals`, push notifications, and diagnostics modules). These are case-by-case judgment calls and not blocking. Follow-up package sweeps on 2026-05-04: @@ -70,9 +69,12 @@ Follow-up package sweeps on 2026-05-04: CommonJS ESLint config in favor of the existing `eslint.config.mjs`. - `5fb4921` documented the two intentional `@bytelyst/broadcast-client` deep-link diagnostics with narrow lint justifications. +- `1089597` cleared the remaining admin-web React hook/image/unused-symbol + warnings. -Post-agent reconciliation reran `pnpm typecheck` and `pnpm lint`; both pass. -Workspace lint remains at **0 errors** with **173 warnings**. +Post-admin sweep verification reran admin-web lint/typecheck/test/build and +workspace lint; all pass. Workspace lint remains at **0 errors** with **157 +warnings**. ## R. Repo-state observations (not fixed) diff --git a/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md b/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md index c90b6157..a1aeefb5 100644 --- a/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md +++ b/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md @@ -19,7 +19,7 @@ As of the latest local sweep: | `pnpm install -r --prefer-offline` | Pass | Run with `source ~/.zshrc && export GITEA_NPM_TOKEN`. | | `pnpm typecheck` | Pass | All workspace TypeScript compiles. | | `pnpm test` | Pass with known load sensitivity | Full suite passes; isolated reruns cleared prior transient platform/cowork timeouts. | -| `pnpm lint` | Pass | `0` errors. Latest lint rerun after agent reconciliation: `173` warnings. | +| `pnpm lint` | Pass | `0` errors. Latest lint rerun after `1089597`: `157` warnings. | | Known untouched WIP | Present | Do not touch `docker-compose.ecosystem.yml`, `products/nomgap/product.json`, `services/platform-service/src/modules/flags/seed.ts`, or incidental `pnpm-lock.yaml` churn unless explicitly assigned. | Recent warning-cleanup commits: @@ -35,6 +35,7 @@ Recent warning-cleanup commits: | `021f053` | `@lysnrai/platform-service` | Typed predictive campaign event dispatch. | | `04d2398` | `@bytelyst/tracker-web` | Removed roadmap console/module warnings. | | `5fb4921` | `@bytelyst/broadcast-client` | Documented deep-link diagnostics. | +| `1089597` | `@bytelyst/admin-web` | Cleared remaining W2 dashboard warnings. | ## Agent Execution Protocol @@ -252,12 +253,18 @@ Goal: distinguish intentional warning classes from real quality issues. Goal: remove obvious dashboard warnings and review hook warnings safely. -- [ ] `dashboards/admin-web/src/app/(dashboard)/experiments/[id]/page.tsx`: - remove or use unused `Download`. Owner: Stream A. -- [ ] Same file: review `fetchExperimentData` dependency warning. -- [ ] Same file: remove, rename, or use unused `experiment` argument. -- [ ] `dashboards/admin-web/src/app/(dashboard)/experiments/page.tsx`: - remove, render, or rename unused `error`. +- [x] `dashboards/admin-web/src/app/(dashboard)/experiments/[id]/page.tsx`: + remove or use unused `Download`. Done in `1089597`; warning delta `-1`; + verified with admin-web lint/typecheck/test/build and `pnpm lint`. +- [x] Same file: review `fetchExperimentData` dependency warning. Done in + `1089597`; warning delta `-1`; wrapped the loader in `useCallback` and + verified with the same commands. +- [x] Same file: remove, rename, or use unused `experiment` argument. Done in + `1089597`; warning delta `-1`; removed the unused prop and verified with + the same commands. +- [x] `dashboards/admin-web/src/app/(dashboard)/experiments/page.tsx`: + remove, render, or rename unused `error`. Done in `1089597`; warning + delta `-1`; rendered the error state and verified with the same commands. - [x] `dashboards/admin-web/src/app/(dashboard)/feedback/page.tsx`: remove unused `useRouter`. Done in `db4257f`; warning delta `-1`; verified with `pnpm --filter @bytelyst/admin-web typecheck`, @@ -273,24 +280,36 @@ Goal: remove obvious dashboard warnings and review hook warnings safely. - [x] Same file: review `` use and migrate to `next/image` if safe. Done in `db4257f`; warning delta `-1`; used unoptimized `next/image` for the signed screenshot URL and verified with the same commands. -- [ ] `dashboards/admin-web/src/app/(dashboard)/predictive/at-risk/page.tsx`: - remove or use unused `ArrowRight`. -- [ ] Same file: review `loadProfile` dependency warning. -- [ ] Same file: review `loadUsers` dependency warning. -- [ ] `dashboards/admin-web/src/app/(dashboard)/predictive/campaigns/page.tsx`: - remove unused `Tabs`, `TabsContent`, `TabsList`, `TabsTrigger`. -- [ ] Same file: review `loadStats` dependency warning. -- [ ] Same file: review `loadCampaigns` dependency warning. -- [ ] `dashboards/admin-web/src/app/(dashboard)/settings/security/page.tsx`: - review `` use and migrate to `next/image` if safe. -- [ ] `dashboards/admin-web/src/app/(dashboard)/surveys/[id]/page.tsx`: - review `loadSurvey` dependency warning. -- [ ] `dashboards/admin-web/src/app/(dashboard)/surveys/page.tsx`: - review `loadSurveys` dependency warning. -- [x] Run `pnpm --filter @bytelyst/admin-web typecheck`. Done after `db4257f`. -- [x] Run `pnpm --filter @bytelyst/admin-web test`. Done after `db4257f`. +- [x] `dashboards/admin-web/src/app/(dashboard)/predictive/at-risk/page.tsx`: + remove or use unused `ArrowRight`. Done in `1089597`; warning delta `-1`; + verified with the same commands. +- [x] Same file: review `loadProfile` dependency warning. Done in `1089597`; + warning delta `-1`; wrapped the loader in `useCallback` and removed the + unused dialog prop. +- [x] Same file: review `loadUsers` dependency warning. Done in `1089597`; + warning delta `-1`; wrapped the loader in `useCallback`. +- [x] `dashboards/admin-web/src/app/(dashboard)/predictive/campaigns/page.tsx`: + remove unused `Tabs`, `TabsContent`, `TabsList`, `TabsTrigger`. Done in + `1089597`; warning delta `-4`; verified with the same commands. +- [x] Same file: review `loadStats` dependency warning. Done in `1089597`; + warning delta `-1`; wrapped the loader in `useCallback`. +- [x] Same file: review `loadCampaigns` dependency warning. Done in `1089597`; + warning delta `-1`; wrapped the loader in `useCallback`. +- [x] `dashboards/admin-web/src/app/(dashboard)/settings/security/page.tsx`: + review `` use and migrate to `next/image` if safe. Done in + `1089597`; warning delta `-1`; used unoptimized `next/image` for the TOTP + QR data URL. +- [x] `dashboards/admin-web/src/app/(dashboard)/surveys/[id]/page.tsx`: + review `loadSurvey` dependency warning. Done in `1089597`; warning delta + `-1`; wrapped the loader in `useCallback`. +- [x] `dashboards/admin-web/src/app/(dashboard)/surveys/page.tsx`: + review `loadSurveys` dependency warning. Done in `1089597`; warning delta + `-1`; wrapped the loader in `useCallback`. +- [x] Run `pnpm --filter @bytelyst/admin-web typecheck`. Done after `1089597`. +- [x] Run `pnpm --filter @bytelyst/admin-web test`. Done after `1089597`. - [x] Run `pnpm --filter @bytelyst/admin-web exec eslint . --ext .ts,.tsx`. - Done after `db4257f`; admin-web warnings are `23 -> 16`. + Done after `1089597`; admin-web warnings are `16 -> 0`. +- [x] Run `pnpm --filter @bytelyst/admin-web build`. Done after `1089597`. - [ ] Consider an in-browser smoke pass for affected dashboard screens. ### W3. Platform Service Runtime Console Usage @@ -500,3 +519,4 @@ Goal: keep future agents aligned with the true baseline. | 2026-05-04 | `021f053` | Typed predictive campaign event dispatch. | Removed 5 `no-explicit-any` warnings; workspace lint `189` -> `184`. | | 2026-05-04 | `04d2398` | Cleared tracker-web roadmap lint warnings. | Removed 5 workspace warnings; tracker scoped lint is 0 warnings. | | 2026-05-04 | `5fb4921` | Documented broadcast deep-link diagnostics. | Removed 2 no-console warnings; workspace lint `176` -> `174`. | +| 2026-05-04 | `1089597` | Cleared remaining admin-web W2 warnings. | Removed 16 admin-web warnings; workspace lint `173` -> `157`. | diff --git a/docs/HANDOVER.md b/docs/HANDOVER.md index bd9f2f43..cb26a6ba 100644 --- a/docs/HANDOVER.md +++ b/docs/HANDOVER.md @@ -12,7 +12,7 @@ A tooling-backed audit was performed across all 69 workspace packages. `pnpm install / typecheck / lint` pass cleanly on the current workspace. `pnpm lint` was previously failing fast at one package, but a structural eslint config fix + 13 mechanical lint fixes made the lint pipeline run end-to-end. -A fresh rerun on 2026-05-04 shows **0 lint errors / 173 warnings**; the old +A fresh rerun on 2026-05-04 shows **0 lint errors / 157 warnings**; the old 85-error P-sweep handoff is stale. --- @@ -25,7 +25,7 @@ A fresh rerun on 2026-05-04 shows **0 lint errors / 173 warnings**; the old | `pnpm typecheck` | โœ… pass | All 69 packages compile | | `pnpm test` | โœ… pass | ~2,200 tests; cowork-service `EPIPE` flake cleared on focused rerun | | `pnpm lint` (pipeline) | โœ… runs end-to-end | Was bailing fast; this audit unblocked it | -| `pnpm lint` (errors) | โœ… 0 | 173 warnings remain โ€” see `docs/AUDIT_PLATFORM.md` section W | +| `pnpm lint` (errors) | โœ… 0 | 157 warnings remain โ€” see `docs/AUDIT_PLATFORM.md` section W | --- @@ -67,7 +67,8 @@ without inspecting it** โ€” it likely upgraded transitive versions. - **Section W** (active): warnings only. Recent follow-ups cleared admin feedback warnings (`db4257f`), predictive campaign event typing (`021f053`), tracker roadmap/config warnings (`04d2398`), and broadcast-client deep-link - diagnostics (`5fb4921`). + diagnostics (`5fb4921`). The remaining admin-web W2 warnings were cleared in + `1089597`. - **Section R** (housekeeping): token export and peer-warning observations are documented/verified. For the live warning checklist and parallel-agent workflow, use