diff --git a/docs/AUDIT_PLATFORM.md b/docs/AUDIT_PLATFORM.md index 33f88457..a3b16413 100644 --- a/docs/AUDIT_PLATFORM.md +++ b/docs/AUDIT_PLATFORM.md @@ -17,7 +17,7 @@ Legend: ๐Ÿ”ด critical ยท ๐ŸŸ  high ยท ๐ŸŸก medium ยท ๐ŸŸข low ยท | `pnpm install -r` | โœ… pass | No warnings when `GITEA_NPM_TOKEN` is exported after sourcing `~/.zshrc`. | | `pnpm typecheck` | โœ… pass | All TS sources compile (`tsc --noEmit`). | | `pnpm test` | โœ… pass | ~2,200 tests across 18+ test suites; one cowork-service `EPIPE` flake cleared on focused rerun. | -| `pnpm lint` | โœ… pass | Workspace lint exits 0 with 0 errors / 101 warnings after `433c3a5`. See section W. | +| `pnpm lint` | โœ… pass | Workspace lint exits 0 with 0 errors / 93 warnings after `91e08bf`. See section W. | ## A. Lint pipeline blockers (fixed by this audit) @@ -58,8 +58,8 @@ The stale handoff note expected 85 pre-existing errors, but a live rerun on Remaining lint output is warnings only. The largest groups are still `no-console` in CLI tools, code generators, and diagnostic/runtime review areas (`sidecar-monitor`, platform `gen-module`, `migrate-referrals`, push -notifications, and diagnostics modules). These are case-by-case judgment calls -and not blocking. +notifications, and platform diagnostics modules). These are case-by-case +judgment calls and not blocking. Follow-up package sweeps on 2026-05-04: @@ -77,17 +77,19 @@ Follow-up package sweeps on 2026-05-04: output with a file-level lint justification. - `433c3a5` documented intentional `@bytelyst/create-app` generator output and design-token generation output with narrow file-level lint justifications. +- `91e08bf` documented intentional `@bytelyst/diagnostics-client` console + capture with a narrow lint justification. -Post-generator sweep verification reran create-app build/test/lint, -design-tokens scoped lint, and workspace lint; all pass. Workspace lint remains -at **0 errors** with **101 +Post-diagnostics-client sweep verification reran diagnostics-client +build/test/lint and workspace lint; all pass. Workspace lint remains at **0 +errors** with **93 warnings**. ## R. Repo-state observations (not fixed) | # | Observation | Severity | Status | | --- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | :------: | :----------------: | -| R1 | Working tree had 3 uncommitted edits when the audit started: `docker-compose.ecosystem.yml`, `products/nomgap/product.json`, and `services/platform-service/src/modules/flags/seed.ts`. These were finalized separately in `b440330` (`chore(nomgap): finalize product deployment config`). Current working tree is clean after `433c3a5`. | โ€” | โœ… | +| R1 | Working tree had 3 uncommitted edits when the audit started: `docker-compose.ecosystem.yml`, `products/nomgap/product.json`, and `services/platform-service/src/modules/flags/seed.ts`. These were finalized separately in `b440330` (`chore(nomgap): finalize product deployment config`). Current working tree is clean after `91e08bf`. | โ€” | โœ… | | R2 | Local `main` was 17 commits behind `origin/main` at the start of the session. Backup branch `backup/main-20260504-062733` was taken from `origin/main` (the source of truth) โ€” local stale main was _not_ backed up. | ๐ŸŸข | โœ… (backup exists) | | R3 | `.npmrc` references `${GITEA_NPM_TOKEN}`. On this machine `~/.zshrc` defines the token but does not export it, so use `source ~/.zshrc && export GITEA_NPM_TOKEN` before `pnpm`; this silences the WARN. | ๐ŸŸข | โœ… documented | | R4 | Earlier `pnpm install -r` reported peer warnings for `@azure/core-client@^1.10.0`. A live rerun with the token exported reported no peer warnings. | ๐ŸŸข | โœ… verified | diff --git a/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md b/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md index b4767894..f3a52bfc 100644 --- a/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md +++ b/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md @@ -19,26 +19,27 @@ As of the latest local sweep: | `pnpm install -r --prefer-offline` | Pass | Run with `source ~/.zshrc && export GITEA_NPM_TOKEN`. | | `pnpm typecheck` | Pass | All workspace TypeScript compiles. | | `pnpm test` | Pass with known load sensitivity | Full suite passes; isolated reruns cleared prior transient platform/cowork timeouts. | -| `pnpm lint` | Pass | `0` errors. Latest lint rerun after `433c3a5`: `101` warnings. | -| Known untouched WIP | Clear | Prior nomgap deployment WIP was finalized separately in `b440330`; current working tree is clean after `433c3a5`. | +| `pnpm lint` | Pass | `0` errors. Latest lint rerun after `91e08bf`: `93` warnings. | +| Known untouched WIP | Clear | Prior nomgap deployment WIP was finalized separately in `b440330`; current working tree is clean after `91e08bf`. | Recent warning-cleanup commits: -| Commit | Area | Result | -| --------- | ---------------------------- | ----------------------------------------- | -| `4690072` | `@bytelyst/api-client` | Removed `any` from header merging. | -| `afe7d88` | `@bytelyst/monitoring` | Typed fetch test mocks. | -| `b6da94d` | `@bytelyst/tracker-web` | Typed tracker proxy test request helper. | -| `9625999` | `@lysnrai/platform-service` | Removed stale eslint-disable comments. | -| `6978ddb` | `@lysnrai/cowork-service` | Typed test doubles for IPC/Fastify mocks. | -| `db4257f` | `@bytelyst/admin-web` | Cleared feedback page React warnings. | -| `021f053` | `@lysnrai/platform-service` | Typed predictive campaign event dispatch. | -| `04d2398` | `@bytelyst/tracker-web` | Removed roadmap console/module warnings. | -| `5fb4921` | `@bytelyst/broadcast-client` | Documented deep-link diagnostics. | -| `1089597` | `@bytelyst/admin-web` | Cleared remaining W2 dashboard warnings. | -| `5b0fbc2` | `@bytelyst/config` | Documented Key Vault diagnostics. | -| `e9a70ed` | `@lysnrai/monitoring` | Documented health-check CLI output. | -| `433c3a5` | `@bytelyst/create-app` | Documented generator CLI output. | +| Commit | Area | Result | +| --------- | ------------------------------ | ----------------------------------------- | +| `4690072` | `@bytelyst/api-client` | Removed `any` from header merging. | +| `afe7d88` | `@bytelyst/monitoring` | Typed fetch test mocks. | +| `b6da94d` | `@bytelyst/tracker-web` | Typed tracker proxy test request helper. | +| `9625999` | `@lysnrai/platform-service` | Removed stale eslint-disable comments. | +| `6978ddb` | `@lysnrai/cowork-service` | Typed test doubles for IPC/Fastify mocks. | +| `db4257f` | `@bytelyst/admin-web` | Cleared feedback page React warnings. | +| `021f053` | `@lysnrai/platform-service` | Typed predictive campaign event dispatch. | +| `04d2398` | `@bytelyst/tracker-web` | Removed roadmap console/module warnings. | +| `5fb4921` | `@bytelyst/broadcast-client` | Documented deep-link diagnostics. | +| `1089597` | `@bytelyst/admin-web` | Cleared remaining W2 dashboard warnings. | +| `5b0fbc2` | `@bytelyst/config` | Documented Key Vault diagnostics. | +| `e9a70ed` | `@lysnrai/monitoring` | Documented health-check CLI output. | +| `433c3a5` | `@bytelyst/create-app` | Documented generator CLI output. | +| `91e08bf` | `@bytelyst/diagnostics-client` | Documented console capture. | ## Agent Execution Protocol @@ -410,8 +411,10 @@ behavior, CLI output, or noise. - [x] `packages/design-tokens/scripts/generate.ts`: classify as script output. Done in `433c3a5`; warning delta `-1`; retained generation confirmation output and verified with design-tokens scoped lint and workspace lint. -- [ ] `packages/diagnostics-client/src/client.ts`: document console capture as - intentional or add narrow inline disables. +- [x] `packages/diagnostics-client/src/client.ts`: document console capture as + intentional or add narrow inline disables. Done in `91e08bf`; warning + delta `-8`; retained console API wrapping and forwarding behavior and + verified with diagnostics-client build/test/lint and `pnpm lint`. - [x] `services/monitoring/health-check.ts`: classify as CLI health-check. Done in `e9a70ed`; warning delta `-5`; retained health-check console output as the command UI and verified with @@ -489,10 +492,10 @@ Goal: keep future agents aligned with the true baseline. - [ ] Keep `docs/CODEX_RESUME_PROMPT.md` aligned with the latest workflow. - [x] Record warning counts after each batch in this checklist. Use the latest `/tmp/lint-*.log` path and warning count. Post-agent reconciliation - reran `pnpm lint`; current baseline is `0` errors / `101` warnings. + reran `pnpm lint`; current baseline is `0` errors / `93` warnings. - [x] Include commit hashes in this checklist for every completed batch. The current completed batch set is `db4257f`, `021f053`, `04d2398`, - `5fb4921`, `1089597`, `5b0fbc2`, `e9a70ed`, and `433c3a5`. + `5fb4921`, `1089597`, `5b0fbc2`, `e9a70ed`, `433c3a5`, and `91e08bf`. - [x] Keep "do not touch nomgap WIP" instructions visible until those files are resolved by their owner. Done after `b440330`; nomgap deployment config is now committed and the working tree is clean. @@ -542,3 +545,4 @@ Goal: keep future agents aligned with the true baseline. | 2026-05-04 | `5b0fbc2` | Documented config Key Vault diagnostics. | Removed 2 no-console warnings; workspace lint `157` -> `155`. | | 2026-05-04 | `e9a70ed` | Documented monitoring health-check output. | Removed 5 no-console warnings; workspace lint `155` -> `150`. | | 2026-05-04 | `433c3a5` | Documented create-app/design-token generator output. | Removed 50 no-console warnings; workspace lint `151` -> `101`. | +| 2026-05-04 | `91e08bf` | Documented diagnostics-client console capture. | Removed 8 no-console warnings; workspace lint `101` -> `93`. |