bytelyst/learning_ai_common_plat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(audit): record broadcast-client lint cleanup

Browse Source 
Record the broadcast-client warning cleanup hash and latest lint baseline.

Refs: docs/AUDIT_PLATFORM.md section W and docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md W6.

Co-Authored-By: GPT-5 Codex <noreply@openai.com>
This commit is contained in:
Saravana Achu Mac 2026-05-04 16:08:03 -07:00
parent 5fb49215cd
commit 4fd6b68747
2 changed files with 25 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
docs/AUDIT_PLATFORM.md
View File

@ -17,7 +17,7 @@ Legend: 🔴 critical · 🟠 high · 🟡 medium · 🟢 low ·
| `pnpm install -r` | ✅ pass | No warnings when `GITEA_NPM_TOKEN` is exported after sourcing `~/.zshrc`. |
| `pnpm typecheck` | ✅ pass | All TS sources compile (`tsc --noEmit`). |
| `pnpm test` | ✅ pass | ~2,200 tests across 18+ test suites; one cowork-service `EPIPE` flake cleared on focused rerun. |
| `pnpm lint` | ✅ pass | Workspace lint exits 0 with 0 errors. Remaining output is warnings only. See section W. |
| `pnpm lint` | ✅ pass | Workspace lint exits 0 with 0 errors / 174 warning lines after `5fb4921`. See section W. |
## A. Lint pipeline blockers (fixed by this audit)
@ -60,6 +60,11 @@ diagnostic scripts (`create-app`, `keyvault`, `sidecar-monitor`, `gen-module`,
`migrate-referrals`, `roadmap/page.tsx`) plus a few `no-explicit-any` warnings.
These are case-by-case judgment calls and not blocking.
Follow-up package sweep on 2026-05-04: `5fb4921` documented the two intentional
`@bytelyst/broadcast-client` deep-link diagnostics with narrow lint
justifications. Workspace lint remains at **0 errors** and warning lines moved
from **176 → 174**.
## R. Repo-state observations (not fixed)
| # | Observation | Severity | Status |

30
docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md
View File

@ -19,20 +19,21 @@ As of the latest local sweep:
| `pnpm install -r --prefer-offline` | Pass | Run with `source ~/.zshrc && export GITEA_NPM_TOKEN`. |
| `pnpm typecheck` | Pass | All workspace TypeScript compiles. |
| `pnpm test` | Pass with known load sensitivity | Full suite passes; isolated reruns cleared prior transient platform/cowork timeouts. |
| `pnpm lint` | Pass | `0` errors. Latest summarized warning count: `90` warnings after Agent C tracker-web cleanup. |
| `pnpm lint` | Pass | `0` errors. Latest lint warning-line count: `174` after `5fb4921` broadcast-client cleanup. |
| Known untouched WIP | Present | Do not touch `docker-compose.ecosystem.yml`, `products/nomgap/product.json`, `services/platform-service/src/modules/flags/seed.ts`, or incidental `pnpm-lock.yaml` churn unless explicitly assigned. |
Recent warning-cleanup commits:
| Commit | Area | Result |
| --------- | --------------------------- | ----------------------------------------- |
| `4690072` | `@bytelyst/api-client` | Removed `any` from header merging. |
| `afe7d88` | `@bytelyst/monitoring` | Typed fetch test mocks. |
| `b6da94d` | `@bytelyst/tracker-web` | Typed tracker proxy test request helper. |
| `9625999` | `@lysnrai/platform-service` | Removed stale eslint-disable comments. |
| `6978ddb` | `@lysnrai/cowork-service` | Typed test doubles for IPC/Fastify mocks. |
| `db4257f` | `@bytelyst/admin-web` | Cleared feedback page React warnings. |
| `04d2398` | `@bytelyst/tracker-web` | Removed roadmap console/module warnings. |
| Commit | Area | Result |
| --------- | ---------------------------- | ----------------------------------------- |
| `4690072` | `@bytelyst/api-client` | Removed `any` from header merging. |
| `afe7d88` | `@bytelyst/monitoring` | Typed fetch test mocks. |
| `b6da94d` | `@bytelyst/tracker-web` | Typed tracker proxy test request helper. |
| `9625999` | `@lysnrai/platform-service` | Removed stale eslint-disable comments. |
| `6978ddb` | `@lysnrai/cowork-service` | Typed test doubles for IPC/Fastify mocks. |
| `db4257f` | `@bytelyst/admin-web` | Cleared feedback page React warnings. |
| `04d2398` | `@bytelyst/tracker-web` | Removed roadmap console/module warnings. |
| `5fb4921` | `@bytelyst/broadcast-client` | Documented deep-link diagnostics. |
## Agent Execution Protocol
@ -363,7 +364,13 @@ Goal: make script warnings intentional and policy-backed.
Goal: decide package-by-package whether console output is intentional API
behavior, CLI output, or noise.
- [ ] `packages/broadcast-client/src/deep-link.ts`: review console usage.
- [x] `packages/broadcast-client/src/deep-link.ts`: review console usage. Done
in `5fb4921`; warning delta `-2`; retained host-app diagnostics with
narrow lint justifications and verified with
`pnpm --filter @bytelyst/broadcast-client build`,
`pnpm --filter @bytelyst/broadcast-client test`,
`pnpm --filter @bytelyst/broadcast-client exec eslint . --ext .ts,.tsx`,
`pnpm typecheck`, `pnpm test`, and `pnpm lint`.
- [ ] `packages/config/src/keyvault.ts`: review console usage.
- [ ] `packages/create-app/src/generators/agents-md.ts`: classify as
generator/CLI.
@ -489,3 +496,4 @@ Goal: keep future agents aligned with the true baseline.
| 2026-05-04 | `db4257f` | Cleared admin feedback page React warnings. | Removed 7 W2 warnings; lint remains 0 errors. |
| 2026-05-04 | `021f053` | Typed predictive campaign event dispatch. | Removed 5 `no-explicit-any` warnings; workspace lint `189` -> `184`. |
| 2026-05-04 | `04d2398` | Cleared tracker-web roadmap lint warnings. | Removed 5 workspace warnings; tracker scoped lint is 0 warnings. |
| 2026-05-04 | `5fb4921` | Documented broadcast deep-link diagnostics. | Removed 2 no-console warnings; workspace lint `176` -> `174`. |