bytelyst/learning_ai_common_plat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(broadcast-client): document deep-link diagnostics

Browse Source 
What changed:

- Keep broadcast deep-link warnings for host app integration failures.

- Add narrow lint justifications for the two intentional console diagnostics.

Warning impact:

- @bytelyst/broadcast-client no-console: 2 warnings -> 0 warnings.

Verification:

- pnpm --filter @bytelyst/broadcast-client build

- pnpm --filter @bytelyst/broadcast-client test

- pnpm --filter @bytelyst/broadcast-client exec eslint . --ext .ts,.tsx

- pnpm typecheck

- pnpm test

- pnpm lint

Co-Authored-By: GPT-5 Codex <noreply@openai.com>
This commit is contained in:
Saravana Achu Mac 2026-05-04 16:07:13 -07:00
parent f2ca2ed86f
commit 5fb49215cd
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/broadcast-client/src/deep-link.ts
View File

@ -95,6 +95,7 @@ export class DeepLinkRouter {
return true; return true;
} }
// eslint-disable-next-line no-console -- Deep-link consumers need an opt-in diagnostic when a route is dropped.
console.warn(`[DeepLink] No handler for screen: ${route.screen}`); console.warn(`[DeepLink] No handler for screen: ${route.screen}`);
return false; return false;
} }
@ -105,6 +106,7 @@ export class DeepLinkRouter {
process(url: string): boolean { process(url: string): boolean {
const route = this.parseDeepLink(url); const route = this.parseDeepLink(url);
if (!route) { if (!route) {
// eslint-disable-next-line no-console -- Parse failures are intentionally surfaced to host apps during integration.
console.warn(`[DeepLink] Failed to parse: ${url}`); console.warn(`[DeepLink] Failed to parse: ${url}`);
return false; return false;
} }