bytelyst/learning_ai_common_plat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ai-budgets): tighten rollover period filter to exclude stale entries

Browse Source 
- Previous filter only checked e.recordedAt < currentPeriodStart
- Now also checks e.recordedAt >= prevPeriodStart (lower bound)
- Prevents entries from periods before the previous one from inflating
  the spent amount, which would reduce the rollover incorrectly
- 12 ai-budgets tests passing
This commit is contained in:
saravanakumardb1 2026-03-20 06:24:13 -07:00
parent f3a4d915f5
commit 78cb958a6d
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
services/platform-service/src/modules/ai-budgets/routes.ts
View File

@ -330,13 +330,14 @@ export async function aiBudgetRoutes(app: FastifyInstance) {
} }
const prevPeriodStart = toIsoDayBoundary(periodStart(prev, policy.period)); const prevPeriodStart = toIsoDayBoundary(periodStart(prev, policy.period));
// Get spend from previous period // Get spend from previous period only (bounded to prev→current)
const prevEntries = await repo.listSpendEntries(access.productId, { const prevEntries = await repo.listSpendEntries(access.productId, {
policyId: id, policyId: id,
since: prevPeriodStart, since: prevPeriodStart,
}); });
// Only count entries in previous period (before current period) const prevPeriodEntries = prevEntries.filter(
const prevPeriodEntries = prevEntries.filter(e => e.recordedAt < currentPeriodStart); e => e.recordedAt >= prevPeriodStart && e.recordedAt < currentPeriodStart
);
const spentUsd = prevPeriodEntries.reduce((sum, e) => sum + e.costUsd, 0); const spentUsd = prevPeriodEntries.reduce((sum, e) => sum + e.costUsd, 0);
const remainingUsd = Math.max(0, policy.budgetUsd - spentUsd); const remainingUsd = Math.max(0, policy.budgetUsd - spentUsd);
const rolledOverUsd = remainingUsd; // Full rollover — could add a cap later const rolledOverUsd = remainingUsd; // Full rollover — could add a cap later