diff --git a/docs/AUDIT_PLATFORM.md b/docs/AUDIT_PLATFORM.md index a3b16413..12fafcb1 100644 --- a/docs/AUDIT_PLATFORM.md +++ b/docs/AUDIT_PLATFORM.md @@ -17,7 +17,7 @@ Legend: ๐Ÿ”ด critical ยท ๐ŸŸ  high ยท ๐ŸŸก medium ยท ๐ŸŸข low ยท | `pnpm install -r` | โœ… pass | No warnings when `GITEA_NPM_TOKEN` is exported after sourcing `~/.zshrc`. | | `pnpm typecheck` | โœ… pass | All TS sources compile (`tsc --noEmit`). | | `pnpm test` | โœ… pass | ~2,200 tests across 18+ test suites; one cowork-service `EPIPE` flake cleared on focused rerun. | -| `pnpm lint` | โœ… pass | Workspace lint exits 0 with 0 errors / 93 warnings after `91e08bf`. See section W. | +| `pnpm lint` | โœ… pass | Workspace lint exits 0 with 0 errors / 90 warnings after `9cd7089`. See section W. | ## A. Lint pipeline blockers (fixed by this audit) @@ -57,9 +57,8 @@ The stale handoff note expected 85 pre-existing errors, but a live rerun on Remaining lint output is warnings only. The largest groups are still `no-console` in CLI tools, code generators, and diagnostic/runtime review areas -(`sidecar-monitor`, platform `gen-module`, `migrate-referrals`, push -notifications, and platform diagnostics modules). These are case-by-case -judgment calls and not blocking. +(`gen-module`, `migrate-referrals`, push notifications, and platform +diagnostics modules). These are case-by-case judgment calls and not blocking. Follow-up package sweeps on 2026-05-04: @@ -79,17 +78,18 @@ Follow-up package sweeps on 2026-05-04: design-token generation output with narrow file-level lint justifications. - `91e08bf` documented intentional `@bytelyst/diagnostics-client` console capture with a narrow lint justification. +- `9cd7089` documented development-only extraction sidecar health alerts with a + narrow lint justification. -Post-diagnostics-client sweep verification reran diagnostics-client -build/test/lint and workspace lint; all pass. Workspace lint remains at **0 -errors** with **93 +Post-sidecar sweep verification reran extraction-service build/test/lint and +workspace lint; all pass. Workspace lint remains at **0 errors** with **90 warnings**. ## R. Repo-state observations (not fixed) | # | Observation | Severity | Status | | --- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | :------: | :----------------: | -| R1 | Working tree had 3 uncommitted edits when the audit started: `docker-compose.ecosystem.yml`, `products/nomgap/product.json`, and `services/platform-service/src/modules/flags/seed.ts`. These were finalized separately in `b440330` (`chore(nomgap): finalize product deployment config`). Current working tree is clean after `91e08bf`. | โ€” | โœ… | +| R1 | Working tree had 3 uncommitted edits when the audit started: `docker-compose.ecosystem.yml`, `products/nomgap/product.json`, and `services/platform-service/src/modules/flags/seed.ts`. These were finalized separately in `b440330` (`chore(nomgap): finalize product deployment config`). Current working tree is clean after `9cd7089`. | โ€” | โœ… | | R2 | Local `main` was 17 commits behind `origin/main` at the start of the session. Backup branch `backup/main-20260504-062733` was taken from `origin/main` (the source of truth) โ€” local stale main was _not_ backed up. | ๐ŸŸข | โœ… (backup exists) | | R3 | `.npmrc` references `${GITEA_NPM_TOKEN}`. On this machine `~/.zshrc` defines the token but does not export it, so use `source ~/.zshrc && export GITEA_NPM_TOKEN` before `pnpm`; this silences the WARN. | ๐ŸŸข | โœ… documented | | R4 | Earlier `pnpm install -r` reported peer warnings for `@azure/core-client@^1.10.0`. A live rerun with the token exported reported no peer warnings. | ๐ŸŸข | โœ… verified | diff --git a/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md b/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md index f3a52bfc..547727bc 100644 --- a/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md +++ b/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md @@ -19,8 +19,8 @@ As of the latest local sweep: | `pnpm install -r --prefer-offline` | Pass | Run with `source ~/.zshrc && export GITEA_NPM_TOKEN`. | | `pnpm typecheck` | Pass | All workspace TypeScript compiles. | | `pnpm test` | Pass with known load sensitivity | Full suite passes; isolated reruns cleared prior transient platform/cowork timeouts. | -| `pnpm lint` | Pass | `0` errors. Latest lint rerun after `91e08bf`: `93` warnings. | -| Known untouched WIP | Clear | Prior nomgap deployment WIP was finalized separately in `b440330`; current working tree is clean after `91e08bf`. | +| `pnpm lint` | Pass | `0` errors. Latest lint rerun after `9cd7089`: `90` warnings. | +| Known untouched WIP | Clear | Prior nomgap deployment WIP was finalized separately in `b440330`; current working tree is clean after `9cd7089`. | Recent warning-cleanup commits: @@ -40,6 +40,7 @@ Recent warning-cleanup commits: | `e9a70ed` | `@lysnrai/monitoring` | Documented health-check CLI output. | | `433c3a5` | `@bytelyst/create-app` | Documented generator CLI output. | | `91e08bf` | `@bytelyst/diagnostics-client` | Documented console capture. | +| `9cd7089` | `@lysnrai/extraction-service` | Documented sidecar dev alerts. | ## Agent Execution Protocol @@ -421,8 +422,11 @@ behavior, CLI output, or noise. `pnpm --filter @lysnrai/monitoring exec tsc --noEmit`, `pnpm --filter @lysnrai/monitoring exec eslint . --ext .ts,.tsx`, and `pnpm lint`. -- [ ] `services/extraction-service/src/modules/extract/sidecar-monitor.ts`: - review whether console is service runtime or local monitor output. +- [x] `services/extraction-service/src/modules/extract/sidecar-monitor.ts`: + review whether console is service runtime or local monitor output. Done + in `9cd7089`; warning delta `-3`; retained development-only sidecar + health alerts with a scoped lint justification and verified with + extraction-service build/test/lint plus workspace lint. - [ ] Add tests only when behavior is changed, not for pure lint policy. ### W7. Tracker Web Remaining Warnings @@ -492,10 +496,10 @@ Goal: keep future agents aligned with the true baseline. - [ ] Keep `docs/CODEX_RESUME_PROMPT.md` aligned with the latest workflow. - [x] Record warning counts after each batch in this checklist. Use the latest `/tmp/lint-*.log` path and warning count. Post-agent reconciliation - reran `pnpm lint`; current baseline is `0` errors / `93` warnings. + reran `pnpm lint`; current baseline is `0` errors / `90` warnings. - [x] Include commit hashes in this checklist for every completed batch. The current completed batch set is `db4257f`, `021f053`, `04d2398`, - `5fb4921`, `1089597`, `5b0fbc2`, `e9a70ed`, `433c3a5`, and `91e08bf`. + `5fb4921`, `1089597`, `5b0fbc2`, `e9a70ed`, `433c3a5`, `91e08bf`, and `9cd7089`. - [x] Keep "do not touch nomgap WIP" instructions visible until those files are resolved by their owner. Done after `b440330`; nomgap deployment config is now committed and the working tree is clean. @@ -546,3 +550,4 @@ Goal: keep future agents aligned with the true baseline. | 2026-05-04 | `e9a70ed` | Documented monitoring health-check output. | Removed 5 no-console warnings; workspace lint `155` -> `150`. | | 2026-05-04 | `433c3a5` | Documented create-app/design-token generator output. | Removed 50 no-console warnings; workspace lint `151` -> `101`. | | 2026-05-04 | `91e08bf` | Documented diagnostics-client console capture. | Removed 8 no-console warnings; workspace lint `101` -> `93`. | +| 2026-05-04 | `9cd7089` | Documented extraction sidecar dev alerts. | Removed 3 no-console warnings; workspace lint `93` -> `90`. | diff --git a/docs/HANDOVER.md b/docs/HANDOVER.md index 1eb4f6f3..5dfe2540 100644 --- a/docs/HANDOVER.md +++ b/docs/HANDOVER.md @@ -12,7 +12,7 @@ A tooling-backed audit was performed across all 69 workspace packages. `pnpm install / typecheck / lint` pass cleanly on the current workspace. `pnpm lint` was previously failing fast at one package, but a structural eslint config fix + 13 mechanical lint fixes made the lint pipeline run end-to-end. -A fresh rerun on 2026-05-04 shows **0 lint errors / 93 warnings**; the old +A fresh rerun on 2026-05-04 shows **0 lint errors / 90 warnings**; the old 85-error P-sweep handoff is stale. --- @@ -25,7 +25,7 @@ A fresh rerun on 2026-05-04 shows **0 lint errors / 93 warnings**; the old | `pnpm typecheck` | โœ… pass | All 69 packages compile | | `pnpm test` | โœ… pass | ~2,200 tests; cowork-service `EPIPE` flake cleared on focused rerun | | `pnpm lint` (pipeline) | โœ… runs end-to-end | Was bailing fast; this audit unblocked it | -| `pnpm lint` (errors) | โœ… 0 | 93 warnings remain โ€” see `docs/AUDIT_PLATFORM.md` section W | +| `pnpm lint` (errors) | โœ… 0 | 90 warnings remain โ€” see `docs/AUDIT_PLATFORM.md` section W | --- @@ -53,7 +53,7 @@ The nomgap deployment edits that were previously uncommitted were finalized in - `products/nomgap/product.json` โ€” replaces flag set, restructures containers - `services/platform-service/src/modules/flags/seed.ts` โ€” adds 14 lines of seed flags -The current working tree is clean after `91e08bf`. +The current working tree is clean after `9cd7089`. ### 3. The audit doc is the source of truth @@ -68,7 +68,8 @@ The current working tree is clean after `91e08bf`. `1089597`, config Key Vault diagnostics were documented in `5b0fbc2`, monitoring health-check output was documented in `e9a70ed`, and create-app / design-token generator CLI output was documented in `433c3a5`. Diagnostics - client console capture was documented in `91e08bf`. + client console capture was documented in `91e08bf`, and extraction sidecar + development alerts were documented in `9cd7089`. - **Section R** (housekeeping): token export and peer-warning observations are documented/verified. For the live warning checklist and parallel-agent workflow, use