From 97b23f7ca533795d87c9f3b51fc309a4d22b18c8 Mon Sep 17 00:00:00 2001 From: Saravana Achu Mac Date: Mon, 4 May 2026 16:20:56 -0700 Subject: [PATCH] docs(audit): reconcile agent warning sweep --- docs/AUDIT_PLATFORM.md | 37 ++++++++++++++-------- docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md | 23 ++++++++------ docs/HANDOVER.md | 14 +++++--- 3 files changed, 46 insertions(+), 28 deletions(-) diff --git a/docs/AUDIT_PLATFORM.md b/docs/AUDIT_PLATFORM.md index 1d34daa7..b8a7f511 100644 --- a/docs/AUDIT_PLATFORM.md +++ b/docs/AUDIT_PLATFORM.md @@ -12,12 +12,12 @@ Legend: ๐Ÿ”ด critical ยท ๐ŸŸ  high ยท ๐ŸŸก medium ยท ๐ŸŸข low ยท ## 0. Health snapshot -| Check | Result | Notes | -| ----------------- | ------- | ----------------------------------------------------------------------------------------------- | -| `pnpm install -r` | โœ… pass | No warnings when `GITEA_NPM_TOKEN` is exported after sourcing `~/.zshrc`. | -| `pnpm typecheck` | โœ… pass | All TS sources compile (`tsc --noEmit`). | -| `pnpm test` | โœ… pass | ~2,200 tests across 18+ test suites; one cowork-service `EPIPE` flake cleared on focused rerun. | -| `pnpm lint` | โœ… pass | Workspace lint exits 0 with 0 errors / 174 warning lines after `5fb4921`. See section W. | +| Check | Result | Notes | +| ----------------- | ------- | --------------------------------------------------------------------------------------------------- | +| `pnpm install -r` | โœ… pass | No warnings when `GITEA_NPM_TOKEN` is exported after sourcing `~/.zshrc`. | +| `pnpm typecheck` | โœ… pass | All TS sources compile (`tsc --noEmit`). | +| `pnpm test` | โœ… pass | ~2,200 tests across 18+ test suites; one cowork-service `EPIPE` flake cleared on focused rerun. | +| `pnpm lint` | โœ… pass | Workspace lint exits 0 with 0 errors / 173 warnings after post-agent reconciliation. See section W. | ## A. Lint pipeline blockers (fixed by this audit) @@ -55,15 +55,24 @@ The stale handoff note expected 85 pre-existing errors, but a live rerun on ## W. Pre-existing lint warnings -Remaining lint output is warnings only, mostly `no-console` in CLI tools and -diagnostic scripts (`create-app`, `keyvault`, `sidecar-monitor`, `gen-module`, -`migrate-referrals`, `roadmap/page.tsx`) plus a few `no-explicit-any` warnings. -These are case-by-case judgment calls and not blocking. +Remaining lint output is warnings only. The largest groups are still +`no-console` in CLI tools, code generators, and diagnostic/runtime review areas +(`create-app`, `keyvault`, `sidecar-monitor`, platform `gen-module`, +`migrate-referrals`, push notifications, and diagnostics modules), plus the +remaining admin-web React hook/image/unused-symbol warnings. These are +case-by-case judgment calls and not blocking. -Follow-up package sweep on 2026-05-04: `5fb4921` documented the two intentional -`@bytelyst/broadcast-client` deep-link diagnostics with narrow lint -justifications. Workspace lint remains at **0 errors** and warning lines moved -from **176 โ†’ 174**. +Follow-up package sweeps on 2026-05-04: + +- `db4257f` cleared admin feedback page React warnings. +- `021f053` typed predictive campaign event dispatch. +- `04d2398` cleared tracker-web roadmap console warnings and removed the stale + CommonJS ESLint config in favor of the existing `eslint.config.mjs`. +- `5fb4921` documented the two intentional `@bytelyst/broadcast-client` + deep-link diagnostics with narrow lint justifications. + +Post-agent reconciliation reran `pnpm typecheck` and `pnpm lint`; both pass. +Workspace lint remains at **0 errors** with **173 warnings**. ## R. Repo-state observations (not fixed) diff --git a/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md b/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md index d93dbd21..c90b6157 100644 --- a/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md +++ b/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md @@ -19,7 +19,7 @@ As of the latest local sweep: | `pnpm install -r --prefer-offline` | Pass | Run with `source ~/.zshrc && export GITEA_NPM_TOKEN`. | | `pnpm typecheck` | Pass | All workspace TypeScript compiles. | | `pnpm test` | Pass with known load sensitivity | Full suite passes; isolated reruns cleared prior transient platform/cowork timeouts. | -| `pnpm lint` | Pass | `0` errors. Latest lint warning-line count: `174` after `5fb4921` broadcast-client cleanup. | +| `pnpm lint` | Pass | `0` errors. Latest lint rerun after agent reconciliation: `173` warnings. | | Known untouched WIP | Present | Do not touch `docker-compose.ecosystem.yml`, `products/nomgap/product.json`, `services/platform-service/src/modules/flags/seed.ts`, or incidental `pnpm-lock.yaml` churn unless explicitly assigned. | Recent warning-cleanup commits: @@ -32,6 +32,7 @@ Recent warning-cleanup commits: | `9625999` | `@lysnrai/platform-service` | Removed stale eslint-disable comments. | | `6978ddb` | `@lysnrai/cowork-service` | Typed test doubles for IPC/Fastify mocks. | | `db4257f` | `@bytelyst/admin-web` | Cleared feedback page React warnings. | +| `021f053` | `@lysnrai/platform-service` | Typed predictive campaign event dispatch. | | `04d2398` | `@bytelyst/tracker-web` | Removed roadmap console/module warnings. | | `5fb4921` | `@bytelyst/broadcast-client` | Documented deep-link diagnostics. | @@ -149,7 +150,7 @@ and push small commits quickly. If two agents need the same files, serialize. | ------ | ------ | ------- | ---------------------------------------------------------- | --------------------------------------- | ----------- | | A | Done | Agent A | `dashboards/admin-web/**` | W2 feedback page React warnings | `db4257f` | | B | Done | Agent B | `services/platform-service/src/**` only | W4 predictive analytics typing | `021f053` | -| C | Done | Agent C | lint policy, CLI/script files, tracker module config, docs | W7 tracker-web console + module warning | `04d2398` | +| C | Done | Agent C | lint policy, CLI/script files, tracker module config, docs | W7 tracker warning + W6 broadcast diag. | `5fb4921` | ### One-Line Prompts For Parallel Agents @@ -234,7 +235,7 @@ Goal: distinguish intentional warning classes from real quality issues. - [x] Capture a fresh warning inventory: `pnpm lint > /tmp/lint-final-pass.log 2>&1`. Done before `af893c2`; - latest summarized baseline is `0` errors / `189` warnings. + latest reconciliation rerun is `0` errors / `173` warnings. - [ ] Split warnings into buckets: `console`, `no-explicit-any`, `no-unused-vars`, `react-hooks/exhaustive-deps`, `@next/next/no-img-element`, Node module warnings, stale disables. @@ -395,8 +396,10 @@ Goal: finish tracker warnings without hiding real runtime errors. - [x] Decide whether client-side console errors are acceptable for public roadmap actions. Done in `04d2398`; public roadmap load/vote failures now surface in page error state instead of browser console output. -- [ ] Add `"type": "module"` to `dashboards/tracker-web/package.json` only if - it is safe for Next/Vitest/Husky scripts. +- [x] Add `"type": "module"` to `dashboards/tracker-web/package.json` only if + it is safe for Next/Vitest/Husky scripts. Not applicable after + `04d2398`; the safer fix was deleting the stale `eslint.config.js` + because `eslint.config.mjs` is already active. - [x] Alternatively rename/configure `eslint.config.js` to avoid Node's module type warning. Done in `04d2398`; removed stale `eslint.config.js` because `eslint.config.mjs` is already the active Next ESLint config. @@ -448,11 +451,11 @@ Goal: keep future agents aligned with the true baseline. known flakes/load sensitivity if still relevant. - [ ] Keep `docs/CODEX_RESUME_PROMPT.md` aligned with the latest workflow. - [x] Record warning counts after each batch in this checklist. Use the latest - `/tmp/lint-*.log` path and warning count. Agent C recorded - `/tmp/lint-before-agent-c.log` at `95` warnings and - `/tmp/lint-after-agent-c.log` at `90` warnings. -- [x] Include commit hashes in this checklist for every completed batch. Agent C - recorded tracker-web cleanup commit `04d2398`. + `/tmp/lint-*.log` path and warning count. Post-agent reconciliation + reran `pnpm lint`; current baseline is `0` errors / `173` warnings. +- [x] Include commit hashes in this checklist for every completed batch. The + current completed batch set is `db4257f`, `021f053`, `04d2398`, and + `5fb4921`. - [ ] Keep "do not touch nomgap WIP" instructions visible until those files are resolved by their owner. diff --git a/docs/HANDOVER.md b/docs/HANDOVER.md index 653f2f0b..bd9f2f43 100644 --- a/docs/HANDOVER.md +++ b/docs/HANDOVER.md @@ -12,8 +12,8 @@ A tooling-backed audit was performed across all 69 workspace packages. `pnpm install / typecheck / lint` pass cleanly on the current workspace. `pnpm lint` was previously failing fast at one package, but a structural eslint config fix + 13 mechanical lint fixes made the lint pipeline run end-to-end. -A fresh rerun on 2026-05-04 shows **0 lint errors**; the old 85-error P-sweep -handoff is stale. +A fresh rerun on 2026-05-04 shows **0 lint errors / 173 warnings**; the old +85-error P-sweep handoff is stale. --- @@ -25,7 +25,7 @@ handoff is stale. | `pnpm typecheck` | โœ… pass | All 69 packages compile | | `pnpm test` | โœ… pass | ~2,200 tests; cowork-service `EPIPE` flake cleared on focused rerun | | `pnpm lint` (pipeline) | โœ… runs end-to-end | Was bailing fast; this audit unblocked it | -| `pnpm lint` (errors) | โœ… 0 | Warnings only โ€” see `docs/AUDIT_PLATFORM.md` section W | +| `pnpm lint` (errors) | โœ… 0 | 173 warnings remain โ€” see `docs/AUDIT_PLATFORM.md` section W | --- @@ -64,9 +64,15 @@ without inspecting it** โ€” it likely upgraded transitive versions. - **Section A** (โœ… done): 13 lint pipeline blockers fixed in `8f541c9`. - **Section P** (โœ… clear): current workspace lint has 0 errors. -- **Section W** (low priority): warnings only, mostly `no-console` in CLI tools. +- **Section W** (active): warnings only. Recent follow-ups cleared admin + feedback warnings (`db4257f`), predictive campaign event typing (`021f053`), + tracker roadmap/config warnings (`04d2398`), and broadcast-client deep-link + diagnostics (`5fb4921`). - **Section R** (housekeeping): token export and peer-warning observations are documented/verified. +For the live warning checklist and parallel-agent workflow, use +`docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md`. + **Note**: a recent upstream commit tightened the unused-vars rule with `varsIgnorePattern: '^_'`, `caughtErrorsIgnorePattern: '^_'`, etc. โ€” meaning `_`-prefix is now an official escape hatch for intentionally-unused names.