From b52ffc84e10ba7ba50da6a85def9b4d6ef98bb1e Mon Sep 17 00:00:00 2001 From: saravanakumardb1 Date: Fri, 6 Mar 2026 13:53:29 -0800 Subject: [PATCH] docs(fastify-core): resolve follow-up todos --- ...STIFY_CORE_AUDIT_AND_ROADMAP_2026-03-06.md | 28 ++++++++++++++----- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/docs/audits/FASTIFY_CORE_AUDIT_AND_ROADMAP_2026-03-06.md b/docs/audits/FASTIFY_CORE_AUDIT_AND_ROADMAP_2026-03-06.md index 2959956d..eb2e5a0c 100644 --- a/docs/audits/FASTIFY_CORE_AUDIT_AND_ROADMAP_2026-03-06.md +++ b/docs/audits/FASTIFY_CORE_AUDIT_AND_ROADMAP_2026-03-06.md @@ -1020,14 +1020,18 @@ The ecosystem finishes with fewer duplicate patterns and fewer partial migration - Scope: `platform-service` migrated from inline optional JWT parsing to `registerOptionalJwtContext`, bootstrap tests updated, shared-package and service validations passed - Commit: `e4baa2f` - Status: Completed -- [ ] **Increment 4 — Product backend migration sweep (confirmed repos)** - - Scope: confirmed shared JWT helper migrations committed in product backends with isolated backend typechecks passing; verified commits so far: `learning_ai_clock` `8cc21d8`, `learning_ai_fastgap` `84b6da6` - - Commit: `PENDING_DOC_UPDATE_COMMIT_SHA` - - Status: In progress +- [x] **Increment 4 — Product backend migration sweep** + - Scope: shared JWT helper migration completed across product backends with committed repo updates: `learning_ai_clock` `8cc21d8`, `learning_ai_fastgap` `84b6da6`, `learning_voice_ai_agent` `547307e`, `learning_multimodal_memory_agents` `48ff90a` + - Commit: `87f4955` + - Status: Completed - [x] **Increment 5 — Post-migration review fixes** - Scope: audit pass over recent Fastify-core rollout fixes; restored `mcp-server` issuer validation via tested local auth helper, repaired missing `platform-service` imports after helper migration, and isolated `platform-service` bootstrap tests from startup side effects - Commit: `63b0d20` - Status: Completed +- [x] **Increment 6 — Follow-up TODO resolution** + - Scope: resolved product-repo migration ambiguity by confirming and committing remaining `LysnrAI` and `MindLyst` backend diffs; reproduced `platform-service` `EPERM kill` teardown issue under forked workers and fixed it by pinning the service Vitest pool to `threads` + - Commit: `49db2cd` + - Status: Completed ## P0 — Must Do @@ -1035,12 +1039,22 @@ The ecosystem finishes with fewer duplicate patterns and fewer partial migration - [x] Make `startService(...)` signal registration idempotent - [x] Stop forcing unconditional `process.exit(...)` from shared startup helper or make it configurable - [x] Create shared optional bearer JWT hook/helper -- [ ] Migrate all product backends and `mcp-server` to the shared auth helper +- [x] Migrate all product backends and `mcp-server` to the shared auth helper ## Open TODOs / Questions -- **TODO 1** — Reconcile repo-state inconsistency during product backend verification: `LysnrAI`, `MindLyst`, `JarvisJr`, and `PeakPulse` backend server files were validated with the shared helper shape, but only `ChronoMind` and `NomGap` showed commit-worthy diffs in git during this sweep. Confirm whether those other repos were already migrated previously or whether local workspace state masked pending diffs. -- **TODO 2** — Full `platform-service` suite still intermittently exits with Vitest worker teardown `EPERM kill` in this environment even when the isolated `src/server.test.ts` passes. Treat this as environment/test-runner follow-up unless it reproduces as a deterministic assertion failure. +- **TODO 1** — Resolved. `LysnrAI` and `MindLyst` still had real uncommitted backend diffs and were committed in follow-up repo commits; `JarvisJr` and `PeakPulse` were already clean because their shared-helper migrations had already been committed earlier in the sweep. +- **TODO 2** — Resolved. The `platform-service` full-suite `EPERM kill` teardown reproduced under Vitest forked workers and no longer reproduced once `services/platform-service/vitest.config.ts` pinned `test.pool = 'threads'`. + +## Follow-up Findings — 2026-03-06 TODO Resolution + +- **Follow-up 1 — Product repo migration ambiguity reconciled** + - Result: confirmed that the earlier ambiguity was mixed state, not a false alarm. `learning_voice_ai_agent` and `learning_multimodal_memory_agents` still had uncommitted JWT-helper server migrations; `learning_ai_jarvis_jr` and `learning_ai_peakpulse` were already clean. + - Fix commits: `learning_voice_ai_agent` `547307e`, `learning_multimodal_memory_agents` `48ff90a`. + +- **Follow-up 2 — `platform-service` Vitest teardown issue rooted in worker mode** + - Result: `pnpm --filter @lysnrai/platform-service exec vitest run --pool=forks` reproduced the `kill EPERM` tinypool teardown failure in this mac/Node 25 environment, while `--pool=threads` and the isolated bootstrap test passed. + - Fix: pinned `pool: 'threads'` in `services/platform-service/vitest.config.ts` (`49db2cd`) and revalidated the full suite via the normal package test script. ## Review Findings — 2026-03-06 Follow-up Pass