bytelyst/learning_ai_common_plat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(audit): mark admin feedback warning cleanup

Browse Source 
What changed:

- Recorded admin-web feedback warning cleanup commit db4257f.

- Marked the four feedback W2 checklist items and admin-web scoped gates.

Warning impact:

- Feedback page warnings: 7 -> 0.

- Admin-web warnings: 23 -> 16.

Verification:

- pnpm --filter @bytelyst/admin-web typecheck

- pnpm --filter @bytelyst/admin-web test

- pnpm --filter @bytelyst/admin-web exec eslint . --ext .ts,.tsx

- pnpm lint
This commit is contained in:
Saravana Achu Mac 2026-05-04 16:01:46 -07:00
parent e8d762a6eb
commit bb5eeb2a05
1 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md
View File

@ -31,6 +31,7 @@ Recent warning-cleanup commits:
| `b6da94d` | `@bytelyst/tracker-web` | Typed tracker proxy test request helper. |
| `9625999` | `@lysnrai/platform-service` | Removed stale eslint-disable comments. |
| `6978ddb` | `@lysnrai/cowork-service` | Typed test doubles for IPC/Fastify mocks. |
| `db4257f` | `@bytelyst/admin-web` | Cleared feedback page React warnings. |
## Agent Execution Protocol
@ -254,11 +255,21 @@ Goal: remove obvious dashboard warnings and review hook warnings safely.
- [ ] Same file: remove, rename, or use unused `experiment` argument.
- [ ] `dashboards/admin-web/src/app/(dashboard)/experiments/page.tsx`:
remove, render, or rename unused `error`.
- [ ] `dashboards/admin-web/src/app/(dashboard)/feedback/page.tsx`:
remove unused `useRouter`.
- [ ] Same file: review `fetchFeedback` dependency warning.
- [ ] Same file: rename unused caught `err` values to `_err` or handle them.
- [ ] Same file: review `<img>` use and migrate to `next/image` if safe.
- [x] `dashboards/admin-web/src/app/(dashboard)/feedback/page.tsx`:
remove unused `useRouter`. Done in `db4257f`; warning delta `-1`;
verified with `pnpm --filter @bytelyst/admin-web typecheck`,
`pnpm --filter @bytelyst/admin-web test`,
`pnpm --filter @bytelyst/admin-web exec eslint . --ext .ts,.tsx`,
and `pnpm lint`.
- [x] Same file: review `fetchFeedback` dependency warning. Done in `db4257f`;
warning delta `-1`; wrapped the loader in `useCallback` and verified with
the same commands.
- [x] Same file: rename unused caught `err` values to `_err` or handle them.
Done in `db4257f`; warning delta `-4`; removed unused catch bindings and
verified with the same commands.
- [x] Same file: review `<img>` use and migrate to `next/image` if safe. Done
in `db4257f`; warning delta `-1`; used unoptimized `next/image` for the
signed screenshot URL and verified with the same commands.
- [ ] `dashboards/admin-web/src/app/(dashboard)/predictive/at-risk/page.tsx`:
remove or use unused `ArrowRight`.
- [ ] Same file: review `loadProfile` dependency warning.
@ -273,9 +284,10 @@ Goal: remove obvious dashboard warnings and review hook warnings safely.
review `loadSurvey` dependency warning.
- [ ] `dashboards/admin-web/src/app/(dashboard)/surveys/page.tsx`:
review `loadSurveys` dependency warning.
- [ ] Run `pnpm --filter @bytelyst/admin-web typecheck`.
- [ ] Run `pnpm --filter @bytelyst/admin-web test`.
- [ ] Run `pnpm --filter @bytelyst/admin-web exec eslint . --ext .ts,.tsx`.
- [x] Run `pnpm --filter @bytelyst/admin-web typecheck`. Done after `db4257f`.
- [x] Run `pnpm --filter @bytelyst/admin-web test`. Done after `db4257f`.
- [x] Run `pnpm --filter @bytelyst/admin-web exec eslint . --ext .ts,.tsx`.
Done after `db4257f`; admin-web warnings are `23 -> 16`.
- [ ] Consider an in-browser smoke pass for affected dashboard screens.
### W3. Platform Service Runtime Console Usage