From bb86bf220e9465502f228049605ae419071c561f Mon Sep 17 00:00:00 2001 From: saravanakumardb1 Date: Sun, 29 Mar 2026 12:52:19 -0700 Subject: [PATCH] fix(use-theme): remove redundant applyTheme from toggleTheme MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit toggleTheme was calling applyTheme() inside the state updater AND the useEffect was also applying on state change — double DOM write. Now toggleTheme relies solely on the useEffect, matching setTheme behavior. --- packages/use-theme/src/use-theme.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/use-theme/src/use-theme.ts b/packages/use-theme/src/use-theme.ts index 5d3ae2a0..649daac6 100644 --- a/packages/use-theme/src/use-theme.ts +++ b/packages/use-theme/src/use-theme.ts @@ -80,10 +80,9 @@ export function useTheme(options?: UseThemeOptions): UseThemeReturn { if (typeof window !== 'undefined') { window.localStorage.setItem(storageKey, next); } - applyTheme(next, attribute); return next; }); - }, [storageKey, attribute]); + }, [storageKey]); return { theme, setTheme, toggleTheme }; }