diff --git a/docs/AUDIT_PLATFORM.md b/docs/AUDIT_PLATFORM.md index 70afdc3e..eabd84db 100644 --- a/docs/AUDIT_PLATFORM.md +++ b/docs/AUDIT_PLATFORM.md @@ -17,7 +17,7 @@ Legend: ๐Ÿ”ด critical ยท ๐ŸŸ  high ยท ๐ŸŸก medium ยท ๐ŸŸข low ยท | `pnpm install -r` | โœ… pass | No warnings when `GITEA_NPM_TOKEN` is exported after sourcing `~/.zshrc`. | | `pnpm typecheck` | โœ… pass | All TS sources compile (`tsc --noEmit`). | | `pnpm test` | โœ… pass | ~2,200 tests across 18+ test suites; prior cowork `EPIPE` cleared on focused rerun, and auth bcrypt timeout reliability was fixed in `d3fbeba`. | -| `pnpm lint` | โœ… pass | Workspace lint exits 0 with 0 errors / 0 warnings after `663dcde`. See section W. | +| `pnpm lint` | โœ… pass | Workspace lint exits 0 with 0 errors / 0 warnings after `663dcde`; final baseline rechecked through `ecfdc90`. See section W. | ## A. Lint pipeline blockers (fixed by this audit) @@ -96,7 +96,7 @@ warnings**. | # | Observation | Severity | Status | | --- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :------: | :----------------: | -| R1 | Working tree had 3 uncommitted edits when the audit started: `docker-compose.ecosystem.yml`, `products/nomgap/product.json`, and `services/platform-service/src/modules/flags/seed.ts`. These were finalized separately in `b440330` (`chore(nomgap): finalize product deployment config`). Current working tree is clean after `663dcde`; `pnpm-lock.yaml` is also clean and was not committed in warning-sweep work. | โ€” | โœ… | +| R1 | Working tree had 3 uncommitted edits when the audit started: `docker-compose.ecosystem.yml`, `products/nomgap/product.json`, and `services/platform-service/src/modules/flags/seed.ts`. These were finalized separately in `b440330` (`chore(nomgap): finalize product deployment config`). Current working tree is clean after `ecfdc90`; `pnpm-lock.yaml` is also clean and was not committed in warning-sweep work. | โ€” | โœ… | | R2 | Local `main` was 17 commits behind `origin/main` at the start of the session. Backup branch `backup/main-20260504-062733` was taken from `origin/main` (the source of truth) โ€” local stale main was _not_ backed up. | ๐ŸŸข | โœ… (backup exists) | | R3 | `.npmrc` references `${GITEA_NPM_TOKEN}`. On this machine `~/.zshrc` defines the token but does not export it, so use `source ~/.zshrc && export GITEA_NPM_TOKEN` before `pnpm`; this silences the WARN. | ๐ŸŸข | โœ… documented | | R4 | Earlier `pnpm install -r` reported peer warnings for `@azure/core-client@^1.10.0`. A live rerun with the token exported reported no peer warnings. | ๐ŸŸข | โœ… verified | @@ -107,5 +107,6 @@ warnings**. 1. **Section A** (this commit) โ€” structural unblocks so `pnpm lint` runs end-to-end again. 2. **Section P** โ€” no current lint errors; no package sweeps needed. -3. **Section W** โ€” case-by-case warning review (defer; warnings only). +3. **Section W** โ€” warning review complete; workspace lint holds at 0 errors / 0 warnings. 4. **Section R** โ€” housekeeping verified/documented. +5. **Auth test reliability** โ€” bcrypt timeout fixed in `d3fbeba` and audit handoff recorded in `ecfdc90`. diff --git a/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md b/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md index d3145a38..784bf079 100644 --- a/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md +++ b/docs/AUDIT_WARNING_COMPLETION_CHECKLIST.md @@ -19,8 +19,8 @@ As of the latest local sweep: | `pnpm install -r --prefer-offline` | Pass | Run with `source ~/.zshrc && export GITEA_NPM_TOKEN`. | | `pnpm typecheck` | Pass | All workspace TypeScript compiles. | | `pnpm test` | Pass with known load sensitivity | Full suite passes; isolated reruns cleared prior transient platform/cowork timeouts. | -| `pnpm lint` | Pass | `0` errors / `0` warnings after `663dcde`. | -| Known untouched WIP | Clear | Prior nomgap deployment WIP was finalized separately in `b440330`; current working tree is clean after `663dcde`. | +| `pnpm lint` | Pass | `0` errors / `0` warnings after `663dcde`; final baseline rechecked through `ecfdc90`. | +| Known untouched WIP | Clear | Prior nomgap deployment WIP was finalized separately in `b440330`; current working tree is clean after `ecfdc90`. | Recent warning-cleanup commits: @@ -151,7 +151,10 @@ Parallel work is safe only when each agent owns a disjoint file set. All agents must start from the same pushed `main`, claim their stream in this document, and push small commits quickly. If two agents need the same files, serialize. -### Active / Claim Table +### Historical Claim Table + +No active claims remain; the warning sweep is complete. This table records the +parallel streams that were used earlier in the cleanup. | Stream | Status | Owner | File ownership | Current target | Last commit | | ------ | ------ | ------- | ---------------------------------------------------------- | --------------------------------------- | ----------- | @@ -419,7 +422,7 @@ Goal: make script warnings intentional and policy-backed. - [x] Run script typecheck/build coverage via package build or `tsx` dry-run where safe. Done in `2c9dc18`; platform-service build, scripts lint, and workspace lint passed. A TODO was added because `migrate-referrals.ts - --help` still imports service config eagerly and requires platform env +--help` still imports service config eagerly and requires platform env vars. ### W6. Shared Package Console Warnings diff --git a/docs/HANDOVER.md b/docs/HANDOVER.md index e9684ad8..12a4fc10 100644 --- a/docs/HANDOVER.md +++ b/docs/HANDOVER.md @@ -1,7 +1,7 @@ # Handover โ€” Common Platform Audit **Last updated**: 2026-05-04 -**Last commit (audit)**: `8f541c9` โ€” `chore(audit): unblock workspace lint pipeline + 13 mechanical fixes` +**Last commit (audit)**: `ecfdc90` โ€” `docs(audit): record auth test reliability fix` **Backup branch**: `backup/main-20260504-062733` (taken from `origin/main` HEAD `46a16f0`) --- @@ -25,7 +25,7 @@ A fresh rerun on 2026-05-04 shows **0 lint errors / 0 warnings**; the old | `pnpm typecheck` | โœ… pass | All 69 packages compile | | `pnpm test` | โœ… pass | ~2,200 tests; prior transient platform/cowork flakes cleared on rerun, auth bcrypt timeout fixed in `d3fbeba` | | `pnpm lint` (pipeline) | โœ… runs end-to-end | Was bailing fast; this audit unblocked it | -| `pnpm lint` | โœ… 0/0 | 0 errors / 0 warnings after `663dcde` | +| `pnpm lint` | โœ… 0/0 | 0 errors / 0 warnings after `663dcde`; baseline rechecked through `ecfdc90` | --- @@ -53,7 +53,7 @@ The nomgap deployment edits that were previously uncommitted were finalized in - `products/nomgap/product.json` โ€” replaces flag set, restructures containers - `services/platform-service/src/modules/flags/seed.ts` โ€” adds 14 lines of seed flags -The current working tree is clean after `663dcde`; `pnpm-lock.yaml` is clean +The current working tree is clean after `ecfdc90`; `pnpm-lock.yaml` is clean and was not committed as part of the warning sweep. ### 3. The audit doc is the source of truth @@ -62,7 +62,7 @@ and was not committed as part of the warning sweep. - **Section A** (โœ… done): 13 lint pipeline blockers fixed in `8f541c9`. - **Section P** (โœ… clear): current workspace lint has 0 errors. -- **Section W** (active): warnings only. Recent follow-ups cleared admin +- **Section W** (โœ… complete): warnings only. Recent follow-ups cleared admin feedback warnings (`db4257f`), predictive campaign event typing (`021f053`), tracker roadmap/config warnings (`04d2398`), and broadcast-client deep-link diagnostics (`5fb4921`). The remaining admin-web W2 warnings were cleared in