learning_ai_common_plat/packages
Saravana Achu Mac 8f541c9f87 chore(audit): unblock workspace lint pipeline + 13 mechanical fixes
The first `pnpm -r exec eslint .` run was bailing at the very first
package (design-tokens), hiding any lint state in the rest of the 69
workspace packages. This commit fixes the structural blockers so the
pipeline runs end-to-end, then sweeps the small, low-risk lint errors
in the next 4 packages it surfaces. Real lint debt that remains
(85 errors, mostly @typescript-eslint/no-unused-vars across many
unrelated packages) is cataloged in docs/AUDIT_PLATFORM.md for follow-
up by package owners.

Structural fixes (eslint config):
  - eslint.config.js (root):
      • New flat-config block for **/*.cjs and **/scripts/**/*.{js,cjs}
        with Node globals (process, console, require, module, __dirname)
        and no-console disabled. CLI scripts legitimately print to
        stdout. This alone clears the 45 errors in design-tokens'
        validate-tokens.cjs.
      • Added XMLHttpRequest + ProgressEvent to browser globals so
        feedback-client compiles.
  - packages/ui/eslint.config.js:
      • Added @typescript-eslint/parser — the package-local override
        replaced (didn't merge with) the root config, so TS syntax was
        being parsed by espree and erroring on every `interface` /
        type import.
      • Added ignores for dist/** (root's ignores aren't inherited).
      • Extended the files glob to .storybook/**/*.{ts,tsx}.

Mechanical lint fixes (no behaviour change):
  - design-tokens/scripts/{validate,token-coverage}.cjs: empty catch
    binding (catch (e) → catch).
  - feedback-client/src/index.ts:
      • captureScreen(): preserve caught error via `{ cause: err }`
        on the rethrown Error (preserve-caught-error rule, real bug —
        previous chain dropped the original stack).
      • captureElement(): rename unused parity params mimeType/quality
        to _mimeType/_quality and document why they exist.
  - logger/__tests__/logger.test.ts: drop unused `LoggerConfig` import.
  - extraction-service/{lib/circuit-breaker,modules/extract/{sidecar-
    monitor,usage}}.test.ts: drop 3 unused vitest/type imports.
  - tracker-web/__tests__/tracker-proxy.test.ts: rename unused local
    `url` → `_url`.

New: docs/AUDIT_PLATFORM.md
  Tooling-backed audit summary (pnpm install / typecheck / test / lint
  results), classification of remaining lint debt by rule, and an
  ordered hand-off plan for package owners to clear the rest with
  `pnpm --filter <pkg> lint:fix` followed by an eyeball review.

Verified before commit:
  - `pnpm typecheck` → pass (all 69 packages compile)
  - `pnpm test`      → pass (~2,200 tests across 18+ suites)
  - `pnpm lint`      → 85 pre-existing errors surfaced (none introduced
    by this commit; all in unrelated packages — see AUDIT_PLATFORM.md
    section P).

Out of scope (left untouched in working tree):
  - In-progress nomgap-on-Vercel migration: docker-compose.ecosystem.yml,
    products/nomgap/product.json, services/platform-service/src/
    modules/flags/seed.ts.
  - pnpm-lock.yaml: my `pnpm install -r` regenerated it (+2.9k/-8.5k
    lines) — not part of the audit, owner should commit deliberately.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-04 14:21:34 -07:00
..
accessibility refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
api-client refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
auth refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
auth-client refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
auth-ui refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
backend-config refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
backend-flags refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
backend-telemetry refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
billing-client fix(billing-client): add missing typescript devDependency 2026-04-13 11:05:26 -07:00
blob refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
blob-client refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
broadcast-client refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
celebrations refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
client-encrypt refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
config refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
cosmos refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
create-app refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
dashboard-components refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
dashboard-shell refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
datastore refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
design-tokens chore(audit): unblock workspace lint pipeline + 13 mechanical fixes 2026-05-04 14:21:34 -07:00
diagnostics-client refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
errors refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
event-store refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
events refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
extraction refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
fastify-auth refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
fastify-core refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
fastify-sse refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
feature-flag-client refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
feedback-client chore(audit): unblock workspace lint pipeline + 13 mechanical fixes 2026-05-04 14:21:34 -07:00
field-encrypt feat(field-encrypt): add CosmosDekStore for production DEK persistence (6 tests) 2026-04-14 11:29:23 -07:00
gentle-notifications refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
kill-switch-client refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
kotlin-platform-sdk feat(native-sdks): add Keychain/SecureStore key derivation to BLFieldEncrypt 2026-03-21 11:10:02 -07:00
llm refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
llm-router refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
logger chore(audit): unblock workspace lint pipeline + 13 mechanical fixes 2026-05-04 14:21:34 -07:00
marketplace-client refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
monitoring refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
offline-queue refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
ollama-client refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
org-client refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
palace refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
platform-client refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
push refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
queue refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
quick-actions refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
react-auth refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
react-native-platform-sdk fix(docker): INFRA-gap-02 unblock full-stack docker compose up 2026-04-16 15:48:32 -07:00
referral-client refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
secure-storage-web refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
speech refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
storage refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
subscription-client fix(subscription-client): extend SubscriptionDoc with platform-service fields 2026-04-13 22:57:13 -07:00
survey-client refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
swift-diagnostics feat(swift-diagnostics): implement Phase 2.2 Swift Client SDK 2026-03-03 09:28:11 -08:00
swift-platform-sdk feat(native-sdks): add Keychain/SecureStore key derivation to BLFieldEncrypt 2026-03-21 11:10:02 -07:00
sync refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
telemetry-client refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
testing refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
time-references refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
ui chore(audit): unblock workspace lint pipeline + 13 mechanical fixes 2026-05-04 14:21:34 -07:00
use-keyboard-shortcuts refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
use-theme refactor(gitea): robust manifest-based publish pipeline 2026-04-13 01:47:03 -07:00
webhook-dispatch fix(webhook-dispatch): add missing typescript + vitest devDependencies 2026-04-13 11:41:34 -07:00