learning_ai_common_plat/eslint.config.js
Saravana Achu Mac 8f541c9f87 chore(audit): unblock workspace lint pipeline + 13 mechanical fixes
The first `pnpm -r exec eslint .` run was bailing at the very first
package (design-tokens), hiding any lint state in the rest of the 69
workspace packages. This commit fixes the structural blockers so the
pipeline runs end-to-end, then sweeps the small, low-risk lint errors
in the next 4 packages it surfaces. Real lint debt that remains
(85 errors, mostly @typescript-eslint/no-unused-vars across many
unrelated packages) is cataloged in docs/AUDIT_PLATFORM.md for follow-
up by package owners.

Structural fixes (eslint config):
  - eslint.config.js (root):
      • New flat-config block for **/*.cjs and **/scripts/**/*.{js,cjs}
        with Node globals (process, console, require, module, __dirname)
        and no-console disabled. CLI scripts legitimately print to
        stdout. This alone clears the 45 errors in design-tokens'
        validate-tokens.cjs.
      • Added XMLHttpRequest + ProgressEvent to browser globals so
        feedback-client compiles.
  - packages/ui/eslint.config.js:
      • Added @typescript-eslint/parser — the package-local override
        replaced (didn't merge with) the root config, so TS syntax was
        being parsed by espree and erroring on every `interface` /
        type import.
      • Added ignores for dist/** (root's ignores aren't inherited).
      • Extended the files glob to .storybook/**/*.{ts,tsx}.

Mechanical lint fixes (no behaviour change):
  - design-tokens/scripts/{validate,token-coverage}.cjs: empty catch
    binding (catch (e) → catch).
  - feedback-client/src/index.ts:
      • captureScreen(): preserve caught error via `{ cause: err }`
        on the rethrown Error (preserve-caught-error rule, real bug —
        previous chain dropped the original stack).
      • captureElement(): rename unused parity params mimeType/quality
        to _mimeType/_quality and document why they exist.
  - logger/__tests__/logger.test.ts: drop unused `LoggerConfig` import.
  - extraction-service/{lib/circuit-breaker,modules/extract/{sidecar-
    monitor,usage}}.test.ts: drop 3 unused vitest/type imports.
  - tracker-web/__tests__/tracker-proxy.test.ts: rename unused local
    `url` → `_url`.

New: docs/AUDIT_PLATFORM.md
  Tooling-backed audit summary (pnpm install / typecheck / test / lint
  results), classification of remaining lint debt by rule, and an
  ordered hand-off plan for package owners to clear the rest with
  `pnpm --filter <pkg> lint:fix` followed by an eyeball review.

Verified before commit:
  - `pnpm typecheck` → pass (all 69 packages compile)
  - `pnpm test`      → pass (~2,200 tests across 18+ suites)
  - `pnpm lint`      → 85 pre-existing errors surfaced (none introduced
    by this commit; all in unrelated packages — see AUDIT_PLATFORM.md
    section P).

Out of scope (left untouched in working tree):
  - In-progress nomgap-on-Vercel migration: docker-compose.ecosystem.yml,
    products/nomgap/product.json, services/platform-service/src/
    modules/flags/seed.ts.
  - pnpm-lock.yaml: my `pnpm install -r` regenerated it (+2.9k/-8.5k
    lines) — not part of the audit, owner should commit deliberately.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-04 14:21:34 -07:00

171 lines
5.0 KiB
JavaScript

import js from '@eslint/js';
import tseslint from '@typescript-eslint/eslint-plugin';
import tsparser from '@typescript-eslint/parser';
export default [
{
ignores: [
'dist/**',
'node_modules/**',
'coverage/**',
'*.config.js',
'*.config.ts',
'**/dist/**',
'__LOCAL_LLMs/**',
],
},
js.configs.recommended,
{
files: ['**/*.ts', '**/*.tsx'],
languageOptions: {
parser: tsparser,
parserOptions: {
ecmaVersion: 2022,
sourceType: 'module',
// project: true, // Disabled for now
},
globals: {
process: 'readonly',
Buffer: 'readonly',
__dirname: 'readonly',
__filename: 'readonly',
Headers: 'readonly',
TextEncoder: 'readonly',
TextDecoder: 'readonly',
RequestInit: 'readonly',
HeadersInit: 'readonly',
Response: 'readonly',
Request: 'readonly',
fetch: 'readonly',
console: 'readonly',
performance: 'readonly',
AbortSignal: 'readonly',
AbortController: 'readonly',
setTimeout: 'readonly',
clearTimeout: 'readonly',
setInterval: 'readonly',
clearInterval: 'readonly',
navigator: 'readonly',
document: 'readonly',
window: 'readonly',
expect: 'readonly',
describe: 'readonly',
it: 'readonly',
test: 'readonly',
beforeEach: 'readonly',
afterEach: 'readonly',
beforeAll: 'readonly',
afterAll: 'readonly',
crypto: 'readonly',
CryptoKey: 'readonly',
SubtleCrypto: 'readonly',
AesGcmParams: 'readonly',
Crypto: 'readonly',
ArrayBufferView: 'readonly',
indexedDB: 'readonly',
IDBDatabase: 'readonly',
IDBRequest: 'readonly',
IDBTransaction: 'readonly',
IDBObjectStore: 'readonly',
Blob: 'readonly',
File: 'readonly',
FormData: 'readonly',
URLSearchParams: 'readonly',
URL: 'readonly',
BodyInit: 'readonly',
ReadableStream: 'readonly',
localStorage: 'readonly',
sessionStorage: 'readonly',
ReactNode: 'readonly',
React: 'readonly',
JSX: 'readonly',
HTMLElement: 'readonly',
HTMLButtonElement: 'readonly',
HTMLSpanElement: 'readonly',
HTMLDivElement: 'readonly',
HTMLInputElement: 'readonly',
HTMLFormElement: 'readonly',
HTMLAnchorElement: 'readonly',
HTMLImageElement: 'readonly',
HTMLTextAreaElement: 'readonly',
HTMLSelectElement: 'readonly',
HTMLLabelElement: 'readonly',
Element: 'readonly',
Event: 'readonly',
KeyboardEvent: 'readonly',
KeyboardEventInit: 'readonly',
MouseEvent: 'readonly',
FocusEvent: 'readonly',
CustomEvent: 'readonly',
StorageEvent: 'readonly',
MediaQueryList: 'readonly',
MutationObserver: 'readonly',
ResizeObserver: 'readonly',
IntersectionObserver: 'readonly',
EventTarget: 'readonly',
NodeList: 'readonly',
DOMRect: 'readonly',
SVGElement: 'readonly',
XMLHttpRequest: 'readonly',
ProgressEvent: 'readonly',
},
},
plugins: {
'@typescript-eslint': tseslint,
},
rules: {
// TypeScript specific rules
'@typescript-eslint/no-unused-vars': [
'error',
{
argsIgnorePattern: '^_',
varsIgnorePattern: '^_',
caughtErrorsIgnorePattern: '^_',
destructuredArrayIgnorePattern: '^_',
},
],
'@typescript-eslint/explicit-function-return-type': 'off',
'@typescript-eslint/explicit-module-boundary-types': 'off',
'@typescript-eslint/no-explicit-any': 'warn',
// General rules
'no-console': 'warn',
'no-debugger': 'error',
'prefer-const': 'error',
'no-var': 'error',
'no-unused-vars': 'off', // Use TypeScript version
// Import rules - disabled for now
// 'sort-imports': ['error', { ignoreDeclarationSort: true }],
},
},
// Node CJS scripts (build helpers, validators) and `**/scripts/**/*.js` —
// these run on Node directly and need the Node globals (process, console,
// require, module, __dirname). Without this block they trip 40+ no-undef
// errors and break `pnpm lint` for the whole workspace.
{
files: ['**/*.cjs', '**/scripts/**/*.js', '**/scripts/**/*.cjs'],
languageOptions: {
ecmaVersion: 2022,
sourceType: 'commonjs',
globals: {
process: 'readonly',
Buffer: 'readonly',
console: 'readonly',
require: 'readonly',
module: 'readonly',
exports: 'readonly',
__dirname: 'readonly',
__filename: 'readonly',
setTimeout: 'readonly',
clearTimeout: 'readonly',
setInterval: 'readonly',
clearInterval: 'readonly',
},
},
rules: {
'no-console': 'off', // CLI scripts legitimately print to stdout
},
},
];