docs(ui): record common ui gap completion

This commit is contained in:
Saravana Achu Mac 2026-05-06 13:49:34 -07:00
parent 09bdf3fbd0
commit 0eda6488e6

View File

@ -59,7 +59,7 @@ Note: common platform had a pre-existing local modification in `packages/ui/src/
|---|---|---|---|---|---|---|
| [x] | 1. Baseline audit and package-source rules | product | Added UI drift audit script and package scripts; documented ownership; kept local common-platform resolution available through sibling checkout without editing `.npmrc`. | Passed: `BYTELYST_PACKAGE_SOURCE=common-plat BYTELYST_COMMON_PLAT_ROOT=/Users/saravana/BytelystAI/learning_ai/learning_ai_common_plat pnpm install -r --frozen-lockfile`; `pnpm run audit:ui`; `pnpm --filter @bytelyst/trading-web typecheck`; `node -e "require('./.pnpmfile.cjs')"`; `git diff --check`. Expected fail: `pnpm run audit:ui:strict` reports 48 raw controls, 21 legacy classes, 520 color literals, 0 direct `@bytelyst/ui` imports. | `f0cdfe6776b34299abed68bc1741204f16d29723` | Strict audit remains disabled until cleanup phase. Existing pnpm `.npmrc` warning for missing `GITEA_NPM_TOKEN` observed; `.npmrc` was not edited. |
| [x] | 2. Common-platform package inventory | product + common | Mapped product needs to existing common packages for UI, design tokens, platform/auth/session, telemetry, diagnostics, feature flags, kill switch, blob/extraction/offline/broadcast/billing/feedback/survey, datastore/config/errors. | Passed: `rg "@bytelyst/" --glob '!node_modules/**' --glob '!pnpm-lock.yaml' --glob '!vendor/**'`; common package manifest inspection; required common package manifest existence checks; `git diff --check`. | `3ed79933422522dfeec524befcff4f2a4c56dfc7` | No common-platform package gap identified for the next adapter/token phases. Dashboard packages should be evaluated after `@bytelyst/ui` adapter work, not before. |
| [ ] | 3. Common-platform UI gap closure | common | Add or adjust reusable primitives only if product migration discovers missing generic capability. | `pnpm --filter @bytelyst/ui run build`; `pnpm --filter @bytelyst/ui exec eslint src --ext .ts,.tsx`; `git diff --check` | Pending | Defer if current `@bytelyst/ui` coverage is enough. |
| [x] | 3. Common-platform UI gap closure | common | Verified common UI already covers the required reusable primitive set; no common-platform code change needed before product adapter work. | Passed in common platform: `pnpm --filter @bytelyst/ui run build`; `pnpm --filter @bytelyst/ui exec eslint src --ext .ts,.tsx`; `git diff --check`. | `09bdf3fbd0d1f8e46631648f90ddeb0f20fd9541` | Deferral recorded: dashboard packages will be evaluated after product adapter work. Common checkout had a pre-existing local `packages/ui/src/components/AppShell.tsx` modification that this migration did not touch. |
| [ ] | 4. Product UI adapter foundation | product | Add `web/src/components/ui/Primitives.tsx` wrapping/re-exporting `@bytelyst/ui`; add `@bytelyst/ui` and `@bytelyst/design-tokens` dependencies through local common-platform resolution. | `BYTELYST_PACKAGE_SOURCE=common-plat pnpm install -r`; `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm run audit:ui`; `git diff --check` | Pending | Direct `@bytelyst/ui` imports should be isolated to adapter. |
| [ ] | 5. Design token alias foundation | product | Import shared design tokens and add global aliases from product tokens to `--bl-*` in web CSS. | `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm --filter @bytelyst/trading-web test -- --runInBand` if supported; `pnpm run audit:ui`; `git diff --check` | Pending | Keep visual behavior stable while aliases are introduced. |
| [ ] | 6. Highest-value workflow migration | product | Migrate the top operator workflow first, preserving E2E-visible text and behavior while replacing raw controls/surfaces with adapter primitives. | Focused DOM tests for changed workflow; `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm run audit:ui`; `git diff --check` | Pending | Candidate workflow: positions / trade plan navigation based on recent active changes. |