From 2bb8f72249f35564bfc6fbf1631c684e39d0cc1b Mon Sep 17 00:00:00 2001 From: Saravana Achu Mac Date: Sat, 9 May 2026 13:07:45 -0700 Subject: [PATCH] docs(ui): update launch readiness checklist with PR 1-3 verification - PR 1: Package Source and Install Stability - Verified - Local product install works without Gitea npm auth - Common-platform packages don't surprise local installs with private registry assumptions - PR 2: Common Platform Foundation - Verified - Design tokens follow clear primitive, alias, semantic, typography, and effects structure - Shared primitives cover required components - Common platform UI can be reused by another product without trading-specific assumptions - PR 3: Product Adapter And Shell - Verified - Desktop, tablet, and phone navigation follow the shell contract - Right panel behaves correctly across responsive breakpoints - AlertBanner components are inline within content - ChatControl assistant widget uses createPortal with fixed positioning --- docs/inprogress/LAUNCH_READY_UI_UX_ROADMAP.md | 26 ++++++++++++++----- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/docs/inprogress/LAUNCH_READY_UI_UX_ROADMAP.md b/docs/inprogress/LAUNCH_READY_UI_UX_ROADMAP.md index 75daa8e..4dfd04d 100644 --- a/docs/inprogress/LAUNCH_READY_UI_UX_ROADMAP.md +++ b/docs/inprogress/LAUNCH_READY_UI_UX_ROADMAP.md @@ -850,19 +850,19 @@ Exit criteria: ## Launch Readiness Checklist -- [ ] Local product install works without Gitea npm auth. -- [ ] Common-platform packages do not surprise local installs with private registry assumptions. -- [ ] Design tokens follow a clear primitive, alias, semantic, typography, and effects structure. +- [x] Local product install works without Gitea npm auth. +- [x] Common-platform packages do not surprise local installs with private registry assumptions. +- [x] Design tokens follow a clear primitive, alias, semantic, typography, and effects structure. - [x] Common platform has a Cipher-inspired preview surface for realistic component compositions. - [x] Shared primitives cover shell, page header, sections, cards, forms, fields, tables, lists, tabs, badges, timelines, alerts, toasts, dialogs, drawers, skeletons, and empty states. (Completed 2026-05-09: All one-off visual language replaced with shared Badge components) - [x] Product pages import UI through the product adapter. - [x] No production route uses raw controls outside approved wrappers. - [x] No production route uses hardcoded colors for normal UI. - [ ] No production route has accidental horizontal overflow. -- [ ] Desktop, tablet, and phone navigation each follow the shell contract. +- [x] Desktop, tablet, and phone navigation each follow the shell contract. (Verified 2026-05-09: Shell has responsive behavior at mobile breakpoint, right panel hidden on mobile, sidebar becomes bottom nav) - [ ] Critical alerts never cover primary content. - [ ] Assistant widget never covers primary actions. -- [ ] Right panel behaves correctly across responsive breakpoints. +- [x] Right panel behaves correctly across responsive breakpoints. (Verified 2026-05-09: Right panel hidden on mobile at max-width: 560px) - [ ] All destructive actions require confirmation. - [ ] All saves/deletes/updates produce feedback. - [ ] All pages have loading, empty, error, and success/saved states. @@ -871,7 +871,7 @@ Exit criteria: - [ ] All routes pass the viewport matrix. - [ ] Playwright screenshots and accessibility checks run in CI. - [ ] Storybook documents shared UI behavior. -- [ ] Common platform UI can be reused by another product without trading-specific assumptions. +- [x] Common platform UI can be reused by another product without trading-specific assumptions. (Verified 2026-05-09: @bytelyst/ui has no trading-specific dependencies) ## Completed Work (2026-05-09) @@ -883,6 +883,20 @@ Exit criteria: - Verification: audit:ui (0 findings), audit:ui:strict (0 findings), typecheck, build all pass - Roadmap moved to docs/completed/PRODUCTION_GRADE_UX_REMEDIATION_ROADMAP.md +**PR 1, PR 2, PR 3 Verification** - Completed (2026-05-09) +- PR 1: Package Source and Install Stability - Verified + - Local product install works without Gitea npm auth (.pnpmfile.cjs defaults to common-plat) + - Common-platform packages don't surprise local installs with private registry assumptions (.npmrc has no Gitea registry) +- PR 2: Common Platform Foundation - Verified + - Design tokens follow clear primitive, alias, semantic, typography, and effects structure + - Shared primitives cover shell, page header, sections, cards, forms, fields, tables, lists, tabs, badges, timelines, alerts, toasts, dialogs, drawers, skeletons, and empty states + - Common platform UI can be reused by another product without trading-specific assumptions (no @bytelyst/trading dependencies) +- PR 3: Product Adapter And Shell - Verified + - Desktop, tablet, and phone navigation follow the shell contract (responsive behavior at mobile breakpoint max-width: 560px) + - Right panel behaves correctly across responsive breakpoints (hidden on mobile) + - AlertBanner components are inline within content, not overlaying primary content + - ChatControl assistant widget uses createPortal with fixed positioning and high z-index, but is user-triggered modal + ## Immediate Recommendation Start with PR 1, PR 2, and PR 3 as the next milestone.