Close UI migration roadmap

This commit is contained in:
root 2026-05-09 01:23:44 +00:00
parent 3141260045
commit 43a0fa4a8f

View File

@ -86,11 +86,12 @@ Note: common platform had a pre-existing local modification in `packages/ui/src/
| [x] | 13. Strict baseline enforcement | product | Added `pnpm audit:ui:strict` to the root `pnpm verify` workflow and updated README verification guidance so the clean UI migration baseline is enforced in standard repo verification instead of remaining advisory-only. | Passed: `sh -n scripts/verify.sh`; `BYTELYST_PACKAGE_SOURCE=common-plat pnpm --filter @bytelyst/trading-web typecheck`; `BYTELYST_PACKAGE_SOURCE=common-plat pnpm run audit:ui`; `BYTELYST_PACKAGE_SOURCE=common-plat pnpm run audit:ui:strict`; `git diff --check`. | `c6a05d5eb04989f4226d50f0dd7be490a0489dc1` | Strict audit is now part of the default root verification path. This slice changed only repo verification/docs; no trading-domain behavior changed. |
## Remaining Work
## Completion Status
- **Keep strict audit on the clean baseline**: With the current zero-debt audit, future slices should keep `pnpm run audit:ui` and `pnpm run audit:ui:strict` green unless new debt is intentionally introduced and documented.
- **Standardize new product surfaces through the adapter first**: Continue preferring adapter/common primitives for product-agnostic UI while keeping trading workflows and semantic chart palettes product-owned.
- **Verify after each slice**: Run targeted DOM tests for touched views, web typecheck, UI audit, and `git diff --check`.
- **Migration status**: Complete. All roadmap phases are checked complete and the strict UI baseline is enforced in `pnpm verify`.
- **Final verification on the closed baseline**: Passed `BYTELYST_PACKAGE_SOURCE=common-plat pnpm verify`, `BYTELYST_PACKAGE_SOURCE=common-plat pnpm run audit:ui:strict`, and `git diff --check`.
- **Source-linked common-platform note**: Because `web/vite.config.ts` aliases `@bytelyst/ui` to `/opt/bytelyst/learning_ai_common_plat/packages/ui/src/index.ts` when the local checkout is present, full verification requires the local common-platform checkout to have its own dependencies installed.
- **Ongoing maintenance rule**: Future UI work should keep `pnpm run audit:ui`, `pnpm run audit:ui:strict`, and adapter-first usage green unless a deliberate, documented deferral is accepted.
## Running Notes
@ -99,21 +100,11 @@ Note: common platform had a pre-existing local modification in `packages/ui/src/
- Keep Gitea and vendor support available; use local common platform for implementation and verification.
- Commit and push each implementation step, then update this roadmap with commit hash and verification notes in a separate commit.
## Next Agent Handoff
## Closure Notes
Use this document as the live source of truth for the remaining UI/UX platform-core migration. Before continuing, pull the latest repo state and rebase any local branch on top of the pushed roadmap updates:
```bash
git fetch origin
git pull --rebase origin main
```
Then read this file end-to-end and continue from the enforced post-phase-13 baseline:
- **Current phase**: 13 is complete. New work should start from the enforced zero-debt baseline rather than reopening legacy drift.
- **Roadmap state**: Closed. This migration no longer has unchecked execution items.
- **Current audit baseline**: 0 direct `@bytelyst/ui` imports outside the adapter, 0 raw production controls outside approved primitives, 0 legacy global surface classes, and 0 hardcoded color literals in product code.
- **Audit note**: `web/src/index.css` token-definition literals are intentionally excluded from the hardcoded-color audit because they are the theme-source baseline.
- **Next focus**: keep future UI slices on the enforced strict baseline, prefer adapter/common primitives first, and only introduce new product-local styling when it encodes trading semantics.
- **Verification after each slice**: run `pnpm run audit:ui`, targeted DOM tests for touched files, `pnpm --filter @bytelyst/trading-web typecheck`, and `git diff --check`; add `pnpm --filter @bytelyst/trading-web lint`, targeted Vitest slices, and `pnpm --filter @bytelyst/trading-web build` before major commits or adapter-related changes.
- **Roadmap update requirement**: after every implementation commit, update the roadmap row/checkboxes with the new status, final audit counts, exact verification commands, commit hash, and any deferrals or environment blockers.
- **Commit/push rule**: keep commits small and scoped, push each completed slice, then update this document in a follow-up docs commit so the next agent can resume without reconstructing context.
- **Future work rule**: Any new UI slice should start from the enforced zero-debt baseline, prefer adapter/common primitives first, and only introduce product-local styling when it encodes trading semantics.
- **Verification rule**: For future UI changes, run `pnpm run audit:ui`, `pnpm run audit:ui:strict`, targeted DOM tests for touched files, `pnpm --filter @bytelyst/trading-web typecheck`, and `git diff --check`; add `pnpm --filter @bytelyst/trading-web lint` and `pnpm --filter @bytelyst/trading-web build` before larger commits.
- **Docs update rule**: If future UI work changes the baseline or introduces an accepted deferral, add a new roadmap row with the exact verification commands, results, and commit hash.