bytelyst/learning_ai_invt_trdg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(D6): mark editor timer cleanup complete

Browse Source
This commit is contained in:
Saravana Achu Mac 2026-05-04 17:51:23 -07:00
parent 2089b9aa16
commit 68c8a55ea4
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/AUDIT_REDESIGN.md
View File

@ -58,7 +58,7 @@ Status: ⬜ open · 🟦 in PR · ✅ fixed (commit hash on the right).
| D3 | `TickerHeader` exchange is hard-coded "NASDAQ". | 🟢 | ✅ | 1e502b9 |
| D4 | `ScreenerView` "More sectors…" `<select>` doesn't visually highlight the chosen sector pill once selected. | 🟡 | ✅ | 3bf1ca7 |
| D5 | Layout is fixed-width (72 px sidebar + 308 px right panel). Breaks below ~1024 px viewport. No mobile-web responsive breakpoints. | 🟠 | ✅ | a9c33b1 |
| D6 | `VisualRuleBuilder` and `CodeStrategyEditor` use `setTimeout` without cleanup — leak warning if component unmounts mid-timer. | 🟢 | ⬜ | |
| D6 | `VisualRuleBuilder` and `CodeStrategyEditor` use `setTimeout` without cleanup — leak warning if component unmounts mid-timer. | 🟢 | ✅ | 2089b9a |
| D7 | No keyboard shortcuts (⌘K search, ⌘S save in code editor, ⌘Enter run backtest). | 🟢 | ⬜ | |
| D8 | `EmptyState` ticker chips are hard-coded equities. For a crypto-config bot the chips don't apply. | 🟢 | ⬜ | |
| D9 | No `prefers-reduced-motion` handling on spinners / animations. | 🟢 | ⬜ | |

2
docs/COMPLETION_CHECKLIST.md
View File

@ -419,7 +419,7 @@ Expected platform result:
keyboard and screen-reader state remains clear, and sorting/filtering remains
unchanged.
- [ ] `D6` Clean up editor timers.
- [x] `D6` Clean up editor timers. Implementation: `2089b9a`.
Acceptance: `VisualRuleBuilder` and `CodeStrategyEditor` clear any save/status
timers on unmount and do not set state after unmount.