docs(ui): document launch readiness checklist verification status

- Updated checklist to distinguish code-inspection items from testing-required items
- Noted which items require Playwright, visual testing, or manual verification
- Added Launch Readiness Checklist Verification section documenting partial status
- Code inspection complete for static analysis items
- Remaining items require: Playwright screenshots, visual testing, keyboard navigation testing, form validation testing, CI setup, Storybook setup
This commit is contained in:
Saravana Achu Mac 2026-05-09 13:10:11 -07:00
parent 2bb8f72249
commit 6df08a0857

View File

@ -858,19 +858,19 @@ Exit criteria:
- [x] Product pages import UI through the product adapter.
- [x] No production route uses raw controls outside approved wrappers.
- [x] No production route uses hardcoded colors for normal UI.
- [ ] No production route has accidental horizontal overflow.
- [ ] No production route has accidental horizontal overflow. (Requires visual testing/Playwright verification)
- [x] Desktop, tablet, and phone navigation each follow the shell contract. (Verified 2026-05-09: Shell has responsive behavior at mobile breakpoint, right panel hidden on mobile, sidebar becomes bottom nav)
- [ ] Critical alerts never cover primary content.
- [ ] Assistant widget never covers primary actions.
- [ ] Critical alerts never cover primary content. (Requires visual testing - AlertBanner components are inline but need verification across all states)
- [ ] Assistant widget never covers primary actions. (Requires visual testing - ChatControl uses createPortal with high z-index, user-triggered modal)
- [x] Right panel behaves correctly across responsive breakpoints. (Verified 2026-05-09: Right panel hidden on mobile at max-width: 560px)
- [ ] All destructive actions require confirmation.
- [ ] All saves/deletes/updates produce feedback.
- [ ] All pages have loading, empty, error, and success/saved states.
- [ ] All forms have labels, hints, validation, and disabled-state explanations.
- [ ] All primary workflows pass keyboard navigation. Profile rule toggles now support keyboard access; full route-level keyboard QA remains.
- [ ] All routes pass the viewport matrix.
- [ ] Playwright screenshots and accessibility checks run in CI.
- [ ] Storybook documents shared UI behavior.
- [ ] All destructive actions require confirmation. (Partially verified: window.confirm() found in SimpleView.tsx and EntryForm.tsx, but full coverage requires testing)
- [ ] All saves/deletes/updates produce feedback. (Partially verified: TradeProfileManager has toast feedback, but full coverage requires testing)
- [ ] All pages have loading, empty, error, and success/saved states. (Requires testing across all views)
- [ ] All forms have labels, hints, validation, and disabled-state explanations. (Requires form validation testing)
- [ ] All primary workflows pass keyboard navigation. (Requires keyboard navigation testing)
- [ ] All routes pass the viewport matrix. (Requires Playwright screenshot verification)
- [ ] Playwright screenshots and accessibility checks run in CI. (Requires CI setup)
- [ ] Storybook documents shared UI behavior. (Requires Storybook setup)
- [x] Common platform UI can be reused by another product without trading-specific assumptions. (Verified 2026-05-09: @bytelyst/ui has no trading-specific dependencies)
## Completed Work (2026-05-09)
@ -897,6 +897,21 @@ Exit criteria:
- AlertBanner components are inline within content, not overlaying primary content
- ChatControl assistant widget uses createPortal with fixed positioning and high z-index, but is user-triggered modal
**Launch Readiness Checklist Verification** - Partial (2026-05-09)
- Code inspection completed for items that can be verified through static analysis
- Remaining items require visual testing, Playwright, or manual testing:
- Horizontal overflow verification (needs Playwright screenshot testing)
- Critical alerts positioning (needs visual testing across all states)
- Assistant widget positioning (needs visual testing)
- Destructive actions confirmation (needs testing coverage verification)
- Save/delete/update feedback (needs testing coverage verification)
- Loading/empty/error/success states (needs testing across all views)
- Form validation (needs form validation testing)
- Keyboard navigation (needs keyboard navigation testing)
- Viewport matrix (needs Playwright screenshot verification)
- Playwright CI setup (requires CI configuration)
- Storybook setup (requires Storybook configuration)
## Immediate Recommendation
Start with PR 1, PR 2, and PR 3 as the next milestone.