bytelyst/learning_ai_invt_trdg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(E1): mark Monaco lazy-load complete

Browse Source
This commit is contained in:
Saravana Achu Mac 2026-05-04 18:04:16 -07:00
parent 8a8c313ee8
commit a09276a3b5
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/AUDIT_REDESIGN.md
View File

@ -67,7 +67,7 @@ Status: ⬜ open · 🟦 in PR · ✅ fixed (commit hash on the right).
| # | Issue | Severity | Status | Fix commit |
| --- | ---------------------------------------------------------------------------------------------------------------------------------- | :------: | :----: | ---------- |
| E1 | Bundle is 1.08 MB (309 kB gzipped) — Monaco is the bulk. Lazy-load Monaco via `React.lazy`. | 🟠 | ⬜ | |
| E1 | Bundle is 1.08 MB (309 kB gzipped) — Monaco is the bulk. Lazy-load Monaco via `React.lazy`. | 🟠 | ✅ | 8a8c313 |
| E2 | Root `pnpm-lock.yaml` doesn't contain `react-router-dom`, `@monaco-editor/react`, `@dnd-kit/*` (they were installed via `npm` in `web/` causing `web/package-lock.json` and `web/pnpm-lock.yaml` to appear). Workspace builds in CI will fail. **Partial fix**: stray subpackage lockfiles deleted + `.gitignore` updated to prevent recurrence. **Still TODO**: run `pnpm install -r --no-frozen-lockfile` from the repo root on a workstation that has `GITEA_NPM_TOKEN` exported (this session can't reach the private registry → mobile install fails). One-line follow-up commit. | 🔴 | ✅ | 3c9117f |
| E3 | Monaco's web workers (TS/JSON/CSS/HTML) are pulled at runtime from a CDN by default. Need explicit Vite config to bundle workers locally for offline / CSP-strict deployments. | 🟡 | ⬜ | |
| E4 | No README / docs section describing the new layout, env vars (`FMP_API_KEY`), or routes. | 🟡 | ⬜ | |

2
docs/COMPLETION_CHECKLIST.md
View File

@ -438,7 +438,7 @@ Expected platform result:
### Phase 5 - Build, Docs, and Deployment Hardening
- [ ] `E1` Lazy-load Monaco.
- [x] `E1` Lazy-load Monaco. Implementation: `8a8c313`.
Acceptance: code editor chunk is loaded only when needed, bundle size drops
meaningfully, loading fallback is polished, and editor tests still pass.