From b6bd136cf4c6bb406fa9991e2744de015236d561 Mon Sep 17 00:00:00 2001 From: Saravana Achu Mac Date: Wed, 6 May 2026 14:04:47 -0700 Subject: [PATCH] docs(ui): record positions workflow migration --- docs/UI_UX_PLATFORM_CORE_MIGRATION_ROADMAP.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/UI_UX_PLATFORM_CORE_MIGRATION_ROADMAP.md b/docs/UI_UX_PLATFORM_CORE_MIGRATION_ROADMAP.md index 157654e..9ce9739 100644 --- a/docs/UI_UX_PLATFORM_CORE_MIGRATION_ROADMAP.md +++ b/docs/UI_UX_PLATFORM_CORE_MIGRATION_ROADMAP.md @@ -62,7 +62,7 @@ Note: common platform had a pre-existing local modification in `packages/ui/src/ | [x] | 3. Common-platform UI gap closure | common | Verified common UI already covers the required reusable primitive set; no common-platform code change needed before product adapter work. | Passed in common platform: `pnpm --filter @bytelyst/ui run build`; `pnpm --filter @bytelyst/ui exec eslint src --ext .ts,.tsx`; `git diff --check`. | `09bdf3fbd0d1f8e46631648f90ddeb0f20fd9541` | Deferral recorded: dashboard packages will be evaluated after product adapter work. Common checkout had a pre-existing local `packages/ui/src/components/AppShell.tsx` modification that this migration did not touch. | | [x] | 4. Product UI adapter foundation | product | Added `web/src/components/ui/Primitives.tsx` wrapping/re-exporting `@bytelyst/ui`; added `@bytelyst/ui` and `@bytelyst/design-tokens` dependencies through local common-platform resolution; added product status-to-tone mapping. | Passed: `BYTELYST_PACKAGE_SOURCE=common-plat BYTELYST_COMMON_PLAT_ROOT=/Users/saravana/BytelystAI/learning_ai/learning_ai_common_plat pnpm install -r --frozen-lockfile`; `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm run audit:ui`; `git diff --check`. | `833e85ee0e3c41dfbfd3df76c8b89bd3474f9991` | Audit remains at 48 raw controls, 21 legacy classes, 520 color literals, 0 direct `@bytelyst/ui` imports outside adapter. | | [x] | 5. Design token alias foundation | product | Imported shared design tokens and added global aliases from product tokens to `--bl-*` in web CSS. | Passed: `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm --filter @bytelyst/trading-web build`; `pnpm run audit:ui`; `git diff --check`. | `ce85504066a1cfbbbca0c6423f397ccb4f291080` | Used `@bytelyst/design-tokens/generated/tokens.css` because Tailwind/Vite did not resolve the package export alias in CSS `@import`. Audit reports 48 raw controls, 23 legacy classes, 520 color literals, 0 direct `@bytelyst/ui` imports outside adapter. | -| [ ] | 6. Highest-value workflow migration | product | Migrate the top operator workflow first, preserving E2E-visible text and behavior while replacing raw controls/surfaces with adapter primitives. | Focused DOM tests for changed workflow; `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm run audit:ui`; `git diff --check` | Pending | Candidate workflow: positions / trade plan navigation based on recent active changes. | +| [x] | 6. Highest-value workflow migration | product | Migrated Positions workflow profile tabs, order activity filters, lifecycle filters, sort toggles, and pagination controls to adapter Button/Input/Select primitives while preserving visible text and behavior. | Passed: `pnpm --filter @bytelyst/trading-web exec vitest run src/tabs/PositionsTab.dom.test.tsx`; `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm run audit:ui`; `git diff --check`. | `d5a8f36b35f93465a7c80b9192c0d92fe9643060` | Audit raw controls reduced from 48 to 32. Supporting common-platform fix `cd6546ef97a92bf94e0c3893ef9e15bf3bde23d8` made `@bytelyst/ui` root exports Node/Vitest-compatible. Existing common-platform `packages/ui/src/components/AppShell.tsx` local change remains untouched. | | [ ] | 7. Forms, modals, and settings migration | product | Migrate auth/settings/share/create/edit forms to adapter primitives and common modal/dialog patterns. | Focused DOM tests; `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm run audit:ui`; `git diff --check` | Pending | Verify labels and keyboard interaction. | | [ ] | 8. Dashboard, search, and workspace migration | product | Migrate cards/lists/tables/filter chips to Panel, DataList, DataTable, Badge, StatusBadge, and EmptyState. | Focused DOM tests; responsive smoke where available; `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm run audit:ui`; `git diff --check` | Pending | Preserve dense operational layout. | | [ ] | 9. Advanced product-specific surfaces | product | Keep trading-domain logic local while using common primitives for shells, toolbars, menus, panels, lists, status, and diffs. | Focused DOM/unit tests; `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm run audit:ui`; `git diff --check` | Pending | Charts and strategy logic remain product-owned. |