docs(ui): record auth form migration

This commit is contained in:
Saravana Achu Mac 2026-05-06 14:06:04 -07:00
parent 6511326a3e
commit ec705a3d7b

View File

@ -63,7 +63,7 @@ Note: common platform had a pre-existing local modification in `packages/ui/src/
| [x] | 4. Product UI adapter foundation | product | Added `web/src/components/ui/Primitives.tsx` wrapping/re-exporting `@bytelyst/ui`; added `@bytelyst/ui` and `@bytelyst/design-tokens` dependencies through local common-platform resolution; added product status-to-tone mapping. | Passed: `BYTELYST_PACKAGE_SOURCE=common-plat BYTELYST_COMMON_PLAT_ROOT=/Users/saravana/BytelystAI/learning_ai/learning_ai_common_plat pnpm install -r --frozen-lockfile`; `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm run audit:ui`; `git diff --check`. | `833e85ee0e3c41dfbfd3df76c8b89bd3474f9991` | Audit remains at 48 raw controls, 21 legacy classes, 520 color literals, 0 direct `@bytelyst/ui` imports outside adapter. |
| [x] | 5. Design token alias foundation | product | Imported shared design tokens and added global aliases from product tokens to `--bl-*` in web CSS. | Passed: `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm --filter @bytelyst/trading-web build`; `pnpm run audit:ui`; `git diff --check`. | `ce85504066a1cfbbbca0c6423f397ccb4f291080` | Used `@bytelyst/design-tokens/generated/tokens.css` because Tailwind/Vite did not resolve the package export alias in CSS `@import`. Audit reports 48 raw controls, 23 legacy classes, 520 color literals, 0 direct `@bytelyst/ui` imports outside adapter. |
| [x] | 6. Highest-value workflow migration | product | Migrated Positions workflow profile tabs, order activity filters, lifecycle filters, sort toggles, and pagination controls to adapter Button/Input/Select primitives while preserving visible text and behavior. | Passed: `pnpm --filter @bytelyst/trading-web exec vitest run src/tabs/PositionsTab.dom.test.tsx`; `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm run audit:ui`; `git diff --check`. | `d5a8f36b35f93465a7c80b9192c0d92fe9643060` | Audit raw controls reduced from 48 to 32. Supporting common-platform fix `cd6546ef97a92bf94e0c3893ef9e15bf3bde23d8` made `@bytelyst/ui` root exports Node/Vitest-compatible. Existing common-platform `packages/ui/src/components/AppShell.tsx` local change remains untouched. |
| [ ] | 7. Forms, modals, and settings migration | product | Migrate auth/settings/share/create/edit forms to adapter primitives and common modal/dialog patterns. | Focused DOM tests; `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm run audit:ui`; `git diff --check` | Pending | Verify labels and keyboard interaction. |
| [x] | 7. Forms, modals, and settings migration | product | Migrated auth reset/sign-in/sign-up controls to adapter Button/Input primitives while preserving labels, placeholders, button names, and provider-error behavior. | Passed: `pnpm --filter @bytelyst/trading-web exec vitest run src/components/Login.dom.test.tsx src/components/ResetPassword.dom.test.tsx`; `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm run audit:ui`; `git diff --check`. | `6511326a3e5de3e6d2cf4f5ec29c30c3ea98cfe7` | Audit raw controls reduced from 32 to 25. Settings/share/create/edit form debt remains for dashboard/workspace and cleanup phases. |
| [ ] | 8. Dashboard, search, and workspace migration | product | Migrate cards/lists/tables/filter chips to Panel, DataList, DataTable, Badge, StatusBadge, and EmptyState. | Focused DOM tests; responsive smoke where available; `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm run audit:ui`; `git diff --check` | Pending | Preserve dense operational layout. |
| [ ] | 9. Advanced product-specific surfaces | product | Keep trading-domain logic local while using common primitives for shells, toolbars, menus, panels, lists, status, and diffs. | Focused DOM/unit tests; `pnpm --filter @bytelyst/trading-web typecheck`; `pnpm run audit:ui`; `git diff --check` | Pending | Charts and strategy logic remain product-owned. |
| [ ] | 10. Legacy global cleanup and strict audit | product | Remove or greatly reduce old global classes and hardcoded literals; enable strict audit only after accepted debt is cleared. | `pnpm run audit:ui:strict`; `pnpm verify`; `pnpm lint`; `git diff --check` | Pending | Strict mode intentionally fails until this phase. |