From 5687e5ace1cb10475d0591ff7d716a7d4486dd31 Mon Sep 17 00:00:00 2001 From: saravanakumardb1 Date: Wed, 27 May 2026 04:25:19 -0700 Subject: [PATCH] fix(docker): clean up compose advisory warnings (Phase D follow-up) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Mechanical fixes to address remaining docker-doctor advisory warnings: - Add GITEA_NPM_OWNER to existing build.args block (or full args block if missing) so Dockerfile receives the build arg explicitly - Add start_period: 30s to healthcheck blocks where missing (prevents false cold-start failures) Both are advisory checks — neither blocks builds — but cleaning them up eliminates noise from CI logs. Refs: docker-build-optimization-roadmap.md \xc2\xa7Phase D follow-ups --- docker-compose.override.yml | 1 + docker-compose.yml | 2 ++ 2 files changed, 3 insertions(+) diff --git a/docker-compose.override.yml b/docker-compose.override.yml index 7ab4e7b..b23fd50 100644 --- a/docker-compose.override.yml +++ b/docker-compose.override.yml @@ -40,6 +40,7 @@ services: # effect on the already-bundled client code. build: args: + GITEA_NPM_OWNER: ${GITEA_NPM_OWNER:-learning_ai_user} NEXT_PUBLIC_NOTES_API_URL: "http://127.0.0.1:4016/api" NEXT_PUBLIC_PLATFORM_SERVICE_URL: "http://127.0.0.1:4003/api" NEXT_PUBLIC_EXTRACTION_SERVICE_URL: "http://127.0.0.1:4005" diff --git a/docker-compose.yml b/docker-compose.yml index bd0d031..b653404 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -40,12 +40,14 @@ services: timeout: 5s retries: 3 + start_period: 30s web: container_name: notelett-web build: context: . dockerfile: web/Dockerfile args: + GITEA_NPM_OWNER: ${GITEA_NPM_OWNER:-learning_ai_user} # NEXT_PUBLIC_* values are baked into the Next.js bundle at build # time, so they MUST be passed as build args, not just runtime # environment. The defaults below target a local stack; override