docs(ui): record review primitive migration

This commit is contained in:
Saravana Achu Mac 2026-05-06 11:49:06 -07:00
parent c79aa2b6fd
commit 936d2899fe

View File

@ -138,7 +138,7 @@ Repo: `learning_ai_notes`
- [x] Expand `web/src/components/ui/Primitives.tsx` to re-export or wrap the first approved common primitive set. Commit: `b73c969d142728fb854fc3ac1e527272a0ad66f0`. Verified by `pnpm --filter @notelett/web run typecheck`.
- [x] Ensure wrappers map `--bl-*` to `--nl-*` through global token aliases, not per-component hardcoding. Commit: `0f5ddb400b5192004a7a44b41c493900c9f73781`. Verification: `pnpm run install:common-plat --lockfile-only`, `pnpm run install:common-plat --frozen-lockfile`, `pnpm --filter @notelett/web run typecheck`, `pnpm run audit:ui`, adapter token audit, and `git diff --check` passed.
- [x] Add NoteLett defaults for radius, density, focus ring, status mapping, and operational list rows. Commit: `cf5e9c03fd961926358d9f456a67daacca4b8e0c`. Verification: `pnpm --filter @notelett/web run typecheck`, `pnpm run audit:ui`, and `git diff --check` passed.
- [ ] Remove direct product code dependence on `surface-card`, `surface-muted`, `badge`, and `input-shell` for new or migrated screens.
- [x] Remove direct product code dependence on `surface-card`, `surface-muted`, `badge`, and `input-shell` for new or migrated screens. Commit: `c79aa2b6fd701258ed9cc2bc41d6f3532941a4e7` migrated the review UX pilot off legacy globals; remaining legacy matches are pre-existing screens tracked by later phases/UI8. Verification: targeted review raw-control/global-class audit passed.
- [ ] Verify: web typecheck, focused component tests, hardcoded color audit, raw control audit.
### Phase UI3 — Review UX Migration First
@ -154,8 +154,8 @@ The review surface is the highest-value pilot because it is operator-critical an
- `ReviewNoteField`
- `ProposalDiffCard`
- `ReviewTimeline`
- [ ] Use common `Panel`, `Button`, `Badge`, `Textarea`, `ListItemButton`, `DiffCard`, and `Timeline`.
- [ ] Replace raw `button`, `textarea`, and `badge` elements in review UX.
- [x] Use common `Panel`, `Button`, `Badge`, `Textarea`, `ListItemButton`, `DiffCard`, and `Timeline`. Commit: `c79aa2b6fd701258ed9cc2bc41d6f3532941a4e7`. Verification: `pnpm --filter @notelett/web run typecheck`, `pnpm --filter @notelett/web exec playwright test e2e/release-flows.spec.ts --reporter=list --workers=1`, and `git diff --check` passed.
- [x] Replace raw `button`, `textarea`, and `badge` elements in review UX. Commit: `c79aa2b6fd701258ed9cc2bc41d6f3532941a4e7`. Verification: targeted `rg` audit over `reviews/page.tsx`, `ProposalReviewCard.tsx`, and `AgentTimeline.tsx` found no raw review controls or legacy review globals.
- [ ] Add keyboard behavior: queue navigation, select all/clear, approve/reject shortcuts only when focus is safe.
- [ ] Add empty/loading/error states through common components.
- [ ] Verify: web typecheck, web tests, Playwright release-flow review spec, desktop/mobile screenshot check.